Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

./scripts/update should fail fast when permission denied #72

Closed
shalako opened this issue Aug 24, 2015 · 3 comments
Closed

./scripts/update should fail fast when permission denied #72

shalako opened this issue Aug 24, 2015 · 3 comments

Comments

@shalako
Copy link

shalako commented Aug 24, 2015

Trying to checkout a tag took me quite a few tries today, because ./scripts/update didn't give any indication of failing. Actually, it does at the beginning:

Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

But this goes by very quickly, followed by all the submodules being synchronized. https://gist.github.com/shalako/d3a6d5b200a68491e952

Instead, could the script stop once permission is denied?

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/101929980.

@emalm
Copy link
Member

emalm commented Aug 24, 2015

Hi, @shalako,

Sure, sounds like a useful feature of that script! I'll prioritize this for the Diego team.

Thanks,
Eric

@jenspinney
Copy link
Contributor

Hi @shalako,

This should now be fixed, as of this commit: 80019a2

Thanks for pointing it out :)
Jen

jfmyers9 pushed a commit that referenced this issue Mar 2, 2016
Submodule src/github.com/pkg/sftp cbc2879..e84cc8c:
  > Merge pull request #85 from pkg/rootdir
  > Merge pull request #81 from pkg/server-option
  > Merge pull request #80 from pkg/functional-options
  > Merge pull request #78 from pkg/server-readonly
  > Merge pull request #79 from pkg/readme-badges
  > Merge pull request #77 from pkg/namedreturns
  > Merge pull request #75 from pkg/golint
  > Merge pull request #73 from mdlayher/golint
  > Merge pull request #74 from LiterallyElvis/master
  > Merge pull request #72 from mdlayher/master
  > Merge pull request #70 from pkg/fixedbugs/69
  > Merge pull request #67 from mdlayher/master
  > Merge pull request #64 from pkg/fixedbugs/28
  > Merge pull request #63 from pkg/fixedbugs/5
  > Merge pull request #61 from pkg/add-travis
  > Merge pull request #62 from xiu/bugfix/35-cant-remove-directories-on-servu
  > Merge pull request #58 from sykesm/client-realpath
  > Merge pull request #60 from pkg/fixedbugs/57
  > updated contribution guidelines

Signed-off-by: James Myers <jmyers@pivotal.io>
tas-runtime-bot added a commit that referenced this issue Oct 3, 2023
Submodule src/code.cloudfoundry.org/bbs d58365d71..9c7c357ce:
  > Make RetireActualLRP remove the route from gorouter (#72)
Submodule src/code.cloudfoundry.org/credhub-cli ea83747ee..b420ec5c2:
  > Bump go modules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants