Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameterize bosh-lite IP #79

Merged
merged 1 commit into from
Oct 5, 2015
Merged

Parameterize bosh-lite IP #79

merged 1 commit into from
Oct 5, 2015

Conversation

chendrix
Copy link

@chendrix chendrix commented Oct 2, 2015

If anyone wants to deploy to a bosh-lite that's not local, the generate-bosh-lite-manifests script will not work because it's hardcoded to look for the uuid of the director at 192.168.50.4.

We parameterized this--with the default of 192.168.50.4--to allow overrides but have no impact otherwise.

Signed-off-by: Shash Reddy sreddy@pivotal.io

Parameterize bosh-lite IP
c05b2bf 
Signed-off-by: Shash Reddy <sreddy@pivotal.io>
@cfdreddbot
Copy link

Hey chendrix!

Thanks for submitting this pull request!

All pull request authors must have a Contributor License Agreement (CLA) on-file with us. Please sign the appropriate CLA (individual or corporate).

When sending signed CLA please provide your github username in case of individual CLA or the list of github usernames that can make pull requests on behalf of your organization.

If you are confident that you're covered under a Corporate CLA, please make sure you've publicized your membership in the appropriate Github Org, per these instructions.

1 similar comment
@cfdreddbot
Copy link

Hey chendrix!

Thanks for submitting this pull request!

All pull request authors must have a Contributor License Agreement (CLA) on-file with us. Please sign the appropriate CLA (individual or corporate).

When sending signed CLA please provide your github username in case of individual CLA or the list of github usernames that can make pull requests on behalf of your organization.

If you are confident that you're covered under a Corporate CLA, please make sure you've publicized your membership in the appropriate Github Org, per these instructions.

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/104751382.

@emalm
Copy link
Member

emalm commented Oct 2, 2015

Thanks, @chendrix! Hmm, looks like your membership in the cloudfoundry GitHub org is public, so I'm not sure why Dreddbot is hassling you. I'll close and re-open this PR to re-trigger the check.

Best,
Eric

@emalm emalm closed this Oct 2, 2015
@cfdreddbot
Copy link

Hey chendrix!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you've already signed the CLA.

1 similar comment
@cfdreddbot
Copy link

Hey chendrix!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you've already signed the CLA.

@emalm emalm reopened this Oct 2, 2015
@emalm
Copy link
Member

emalm commented Oct 5, 2015

Thanks for the contribution, @chendrix. Ultimately, I think it makes more sense for the Diego manifest-generation scripts to pull the director UUID from the CF manifest (which should be generated with tooling in cf-release), rendering the print-director-stub script unnecessary. I'll discuss that idea with the team shortly. We may also pull in your change as a stopgap measure until that and some other manifest-generation work is done.

Best,
Eric

andrew-edgar added a commit that referenced this pull request Oct 5, 2015
@andrew-edgar
Merge pull request #79 from chendrix/features/parameterize-bosh-lite-ip
627e65f 
Parameterize bosh-lite IP
@andrew-edgar andrew-edgar merged commit 627e65f into cloudfoundry:develop Oct 5, 2015
@andrew-edgar
Copy link
Contributor

Thanks we have merged this pull request and it should be available in the next good build.

@andrew-edgar & @jenspinney

jfmyers9 pushed a commit that referenced this pull request Mar 2, 2016
@ameowlia @jfmyers9
bump sftp
6a3aebf 
Submodule src/github.com/pkg/sftp cbc2879..e84cc8c:
  > Merge pull request #85 from pkg/rootdir
  > Merge pull request #81 from pkg/server-option
  > Merge pull request #80 from pkg/functional-options
  > Merge pull request #78 from pkg/server-readonly
  > Merge pull request #79 from pkg/readme-badges
  > Merge pull request #77 from pkg/namedreturns
  > Merge pull request #75 from pkg/golint
  > Merge pull request #73 from mdlayher/golint
  > Merge pull request #74 from LiterallyElvis/master
  > Merge pull request #72 from mdlayher/master
  > Merge pull request #70 from pkg/fixedbugs/69
  > Merge pull request #67 from mdlayher/master
  > Merge pull request #64 from pkg/fixedbugs/28
  > Merge pull request #63 from pkg/fixedbugs/5
  > Merge pull request #61 from pkg/add-travis
  > Merge pull request #62 from xiu/bugfix/35-cant-remove-directories-on-servu
  > Merge pull request #58 from sykesm/client-realpath
  > Merge pull request #60 from pkg/fixedbugs/57
  > updated contribution guidelines

Signed-off-by: James Myers <jmyers@pivotal.io>
jvshahid added a commit that referenced this pull request Jun 18, 2018
@jvshahid
bump diego-ssh uaa-go-client jwt-go
4081347 
[finishes #155485548](https://www.pivotaltracker.com/story/show/155485548)

Submodule src/code.cloudfoundry.org/diego-ssh 9b3f460a..11745569:
  > Upgrade jwt-go library.
Submodule src/code.cloudfoundry.org/uaa-go-client 0c176509..26b271e3:
  > Ignore validation error when token used before issued
  > go back to using submodules from routing-release
  > Provide correct url
  > Update README
  > all tests passing with newer JWT
  > fixing vet errors
  > Merge pull request #10 from cloudfoundry-incubator/vendor-deps
  > Revert "remove incubator"
  > remove incubator
Submodule src/github.com/dgrijalva/jwt-go f62f64ea..06ea1031:
  > documentation around expected key types
  > Merge branch 'master' of github.com:dgrijalva/jwt-go
  > add options to ParseFromRequest
  > fixed a formatting error in a test
  > documenting changes for upcoming 3.2.0 release
  > Merge pull request #152 from pusher/parse-unverified
  > Merge pull request #219 from geertjanvdk/feat/parse
  > Merge pull request #205 from zamicol/icon_godoc
  > Merge pull request #209 from zhyuri/patch-1
  > Merge pull request #220 from polarina/readme-alt-include
  > Notice about upcoming 4.0.0 release
  > 3.1.0 changelog
  > Merge pull request #218 from zoofood/patch-1
  > updated note on alg type vulnerability
  > Merge pull request #183 from hnakamur/support_rs256_in_jwt_command
  > Merge pull request #196 from dgrijalva/dg/cmd_args
  > Merge pull request #190 from jamesrwhite/patch-1
  > Merge pull request #180 from kevinburke/fix-unreachable
  > Merge pull request #166 from johnlockwood-wf/issue-165-missing-arg
  > Merge pull request #151 from zaichang/FixMigrationGuide
  > Merge pull request #146 from pkieltyka/master
  > Merge pull request #140 from kazhuravlev/patch-1
  > Merge pull request #77 from dgrijalva/release_3_0_0
  > v2.7.0
  > notice about imminent 3.0.0
  > Merge pull request #136 from bruston/keyfunc-typo
  > fixes #135 copy/paste error in rsa decoding tools
  > Merge pull request #132 from abourget/master
  > Merge pull request #133 from johnlockwood-wf/expire-delta
  > release notes
  > expose inner error within ValidationError
  > Merge branch 'master' of https://github.com/emanoelxavier/jwt-go-contr into dg/merge_112
  > cleaned up style and added tests
  > Merge branch 'master' of https://github.com/dakom/jwt-go into dg/pr_121
  > version history update
  > Merge pull request #79 from dgrijalva/dg/none
  > Merge pull request #122 from appleboy/patch-1
  > add 1.6 to travis.yml
  > Merge pull request #107 from Snorlock/bearer-verification
  > Merge pull request #111 from matm/master
  > added supported signing methods
  > Added some clarification and (hopefully) helpful documentation
  > version history
  > signature should be populated after parsing a valid token
  > Merge pull request #98 from dgrijalva/dg/parser
  > use cleaner version of prefix checking (thanks shurcooL)
  > fix array OOB panic (#100)
  > Merge pull request #93 from EnerfisTeam/master
  > Merge branch 'master' of github.com:dgrijalva/jwt-go
  > minor refactor of HMAC verify for legibility.  no functional changes
  > updated documenation of SigningMethod interface
robertjsullivan added a commit that referenced this pull request Mar 12, 2020
@robertjsullivan @flawedmatrix
bump certstrap
8e970db 
Submodule src/github.com/square/certstrap b61237589..bd8b02aa8:
  > Bump Go to 1.13
  > Merge pull request #85 from square/mbyczkowski/better-versioning
  > Merge pull request #81 from square/mbyczkowski/option-for-output
  > Merge pull request #80 from square/dependabot/go_modules/github.com/urfave/cli-1.21.0
  > Merge pull request #79 from square/mbyczkowski/godoc-badge
  > Merge pull request #71 from julianedwards/extractname
  > Merge pull request #77 from julianedwards/newtemplates
  > Merge pull request #73 from defer/ft-text-fixes
  > Merge pull request #69 from square/cs/dockerfile
  > Merge pull request #68 from square/cs/update-cli
  > Merge pull request #67 from square/cs/mod

Co-authored-by: Edwin Xie <exie@pivotal.io>
mariash added a commit that referenced this pull request May 23, 2023
@mariash
bump auction auctioneer bbs cfdot diego-ssh executor inigo rep route-…
8fd21e6 
…emitter

Submodule src/code.cloudfoundry.org/auction 20b5e4eb0..46a89db7a:
  > Support distributed tracing (#11)
Submodule src/code.cloudfoundry.org/auctioneer c72115836..be803dc1e:
  > Support distributed tracing (#13)
Submodule src/code.cloudfoundry.org/bbs 08ff19fb9..f3900dad6:
  > Merge branch 'klapkov-routing_info'
  > Support distributed tracing (#67)
Submodule src/code.cloudfoundry.org/cfdot 9c6e1b442..ef69fb66b:
  > Support distributed tracing (#7)
Submodule src/code.cloudfoundry.org/diego-ssh 62afa2597..1bdd96ca0:
  > Update bbs client calls with trace ID (#48)
Submodule src/code.cloudfoundry.org/executor b452e62e8..1c64887c7:
  > Support distributed tracing (#79)
Submodule src/code.cloudfoundry.org/inigo 3c8b1a8f8..c1bc9f5d9:
  > Run trace id test in inigo (#26)
Submodule src/code.cloudfoundry.org/rep 0de86f227..b9d5c98b7:
  > Support distributed tracing (#42)
Submodule src/code.cloudfoundry.org/route-emitter df496f44d..b6a50dc67:
  > Log trace ID when handling events
  > Pass trace ID from event to bbs client
  > Remove unneeded check
  > Update watcher tests and add new case for the fallback
  > Add fallback to old BBS endpoint
  > Use routing_info bbs endpoint when syncing
tas-runtime-bot pushed a commit that referenced this pull request Feb 29, 2024
bump bbs garden grootfs guardian idmapper
56d1b39 
Submodule src/code.cloudfoundry.org/bbs 6d10e764f..d983f41b1:
  > Use scheduling info instead of the whole desiredLRP  (#79)
Submodule src/garden 8a0cb81e0..90908c40e:
  > Update go.mod dependencies
Submodule src/grootfs d31defcd6..c922682f3:
  > Update go.mod dependencies
Submodule src/guardian 6ef5b63c0..8613e2a1d:
  > Update go.mod dependencies
  > Update guardian to not have packages imported multiple times
Submodule src/idmapper 0ca779f95..fac0b52fc:
  > Update go.mod dependencies
tas-runtime-bot added a commit that referenced this pull request Mar 20, 2024
@tas-runtime-bot
bump bbs cacheddownloader garden grootfs guardian idmapper
7a9fefe 
Submodule src/code.cloudfoundry.org/bbs 32c6e5fa8..807890935:
  > Add staticcheck.conf (#92)
  > Ignore deprecation warnings for deprecated models/functions being used in support of other deprecated code in this codebase (#90)
  > Convert off of deprecated SubscribeToEvents in tests (#91)
Submodule src/code.cloudfoundry.org/cacheddownloader 5972e10b5..5dac67c88:
  > Add staticcheck.conf (#34)
Submodule src/garden f6ad2f4e4..4707b8eb1:
  > Merge pull request #116 from cloudfoundry/add-staticcheck-conf
  > Update go.mod dependencies
Submodule src/grootfs cd9d9baeb..bd1fe7574:
  > Merge pull request #262 from cloudfoundry/add-staticcheck-conf
  > Update go.mod dependencies
Submodule src/guardian 7cc295b5e..ecc454615:
  > Merge pull request #432 from cloudfoundry/add-staticcheck-conf
  > Update go.mod dependencies
Submodule src/idmapper 65baa99d3..9b92bb87f:
  > Merge pull request #79 from cloudfoundry/add-staticcheck-conf
  > Update go.mod dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@chendrix @cfdreddbot @cf-gitbot @emalm @andrew-edgar