Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

loggregator.dropsonde_incoming_port is not defined in manifest diego.yml #81

Closed
ramelito opened this issue Oct 7, 2015 · 5 comments
Closed

loggregator.dropsonde_incoming_port is not defined in manifest diego.yml #81

ramelito opened this issue Oct 7, 2015 · 5 comments

Comments

@ramelito
Copy link

ramelito commented Oct 7, 2015

loggregator.dropsonde_incoming_port is not defined in manifest diego.yml, this leads metron_agent to use default loggregator dropsonde incoming port 3457 not 3459 (from CF). As metron uses wrong port operator or developer can not get metrics from garden containers.
@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/105087208.

@emalm
Copy link
Member

emalm commented Oct 13, 2015

Hi, @ramelito,

Thanks for reporting this issue. Just to clarify, you're overriding that value to 3459 in your CF deployment manifest, but the spiff-based manifest-generation tooling in diego-release isn't propagating it correctly into the separate Diego deployment manifest? And you're referring to the loggregator.dropsonde_incoming_port value, and not metron_agent.dropsonde_incoming_port?

Thanks,
Eric, CF Runtime Diego PM

@ramelito
Copy link
Author

Hi, @ematpl
that's correct, this value is not propagating to diego
i am using loggregator.dropsonde_incoming_port as it's defined in job spec

@emalm
Copy link
Member

emalm commented Oct 19, 2015

Thanks for the confirmation, @ramelito. I've created https://www.pivotaltracker.com/story/show/105646774 in the Diego tracker for the spiff-based manifest-generation system to respect this value from the CF deployment manifest.

Best,
Eric

@emalm
Copy link
Member

emalm commented Dec 9, 2015

Hi, @ramelito, this should be corrected with https://www.pivotaltracker.com/n/projects/1003146/stories/105646774 in Diego 0.1443.0. Closing.

@emalm emalm closed this as completed Dec 9, 2015
jfmyers9 pushed a commit that referenced this issue Mar 2, 2016
@ameowlia @jfmyers9
bump sftp
6a3aebf 
Submodule src/github.com/pkg/sftp cbc2879..e84cc8c:
  > Merge pull request #85 from pkg/rootdir
  > Merge pull request #81 from pkg/server-option
  > Merge pull request #80 from pkg/functional-options
  > Merge pull request #78 from pkg/server-readonly
  > Merge pull request #79 from pkg/readme-badges
  > Merge pull request #77 from pkg/namedreturns
  > Merge pull request #75 from pkg/golint
  > Merge pull request #73 from mdlayher/golint
  > Merge pull request #74 from LiterallyElvis/master
  > Merge pull request #72 from mdlayher/master
  > Merge pull request #70 from pkg/fixedbugs/69
  > Merge pull request #67 from mdlayher/master
  > Merge pull request #64 from pkg/fixedbugs/28
  > Merge pull request #63 from pkg/fixedbugs/5
  > Merge pull request #61 from pkg/add-travis
  > Merge pull request #62 from xiu/bugfix/35-cant-remove-directories-on-servu
  > Merge pull request #58 from sykesm/client-realpath
  > Merge pull request #60 from pkg/fixedbugs/57
  > updated contribution guidelines

Signed-off-by: James Myers <jmyers@pivotal.io>
robertjsullivan added a commit that referenced this issue Mar 12, 2020
@robertjsullivan @flawedmatrix
bump certstrap
8e970db 
Submodule src/github.com/square/certstrap b61237589..bd8b02aa8:
  > Bump Go to 1.13
  > Merge pull request #85 from square/mbyczkowski/better-versioning
  > Merge pull request #81 from square/mbyczkowski/option-for-output
  > Merge pull request #80 from square/dependabot/go_modules/github.com/urfave/cli-1.21.0
  > Merge pull request #79 from square/mbyczkowski/godoc-badge
  > Merge pull request #71 from julianedwards/extractname
  > Merge pull request #77 from julianedwards/newtemplates
  > Merge pull request #73 from defer/ft-text-fixes
  > Merge pull request #69 from square/cs/dockerfile
  > Merge pull request #68 from square/cs/update-cli
  > Merge pull request #67 from square/cs/mod

Co-authored-by: Edwin Xie <exie@pivotal.io>
tas-runtime-bot added a commit that referenced this issue Jun 14, 2023
@tas-runtime-bot
bump auction auctioneer buildpackapplifecycle cacheddownloader cfdot …
fbd571f 
…credhub-cli diego-ssh dockerapplifecycle ecrhelper executor fileserver healthcheck inigo localdriver locket operationq rep route-emitter routing-api routing-info systemcerts vizzini volman workpool garden grootfs guardian idmapper

Submodule src/code.cloudfoundry.org/auction 46a89db7a..4c03ffcd7:
  > Add CODEOWNERS file in preparation for branch protection rules (#16)
Submodule src/code.cloudfoundry.org/auctioneer be803dc1e..ec7efd6f7:
  > Add CODEOWNERS file in preparation for branch protection rules (#14)
Submodule src/code.cloudfoundry.org/buildpackapplifecycle 717bad3b1..cb243e1d2:
  > Merge pull request #48 from Infra-Red/staging-error
  > Merge pull request #62 from geofffranks/main
Submodule src/code.cloudfoundry.org/cacheddownloader a005bb235..2caa6ca34:
  > Add CODEOWNERS file in preparation for branch protection rules (#25)
Submodule src/code.cloudfoundry.org/cfdot ef69fb66b..4d194a115:
  > Add CODEOWNERS file in preparation for branch protection rules (#8)
Submodule src/code.cloudfoundry.org/credhub-cli a97b4319d..aa8fc4e79:
  > Bump go modules
Submodule src/code.cloudfoundry.org/diego-ssh 1bdd96ca0..7461829a9:
  > Add CODEOWNERS file in preparation for branch protection rules (#49)
Submodule src/code.cloudfoundry.org/dockerapplifecycle 0e49eedc7..93dcb397b:
  > Add CODEOWNERS file in preparation for branch protection rules (#12)
Submodule src/code.cloudfoundry.org/ecrhelper 3949c0207..56a9cdc53:
  > Add CODEOWNERS file in preparation for branch protection rules (#3)
Submodule src/code.cloudfoundry.org/executor d6dd1132b..2c29c7e2f:
  > Add CODEOWNERS file in preparation for branch protection rules (#81)
Submodule src/code.cloudfoundry.org/fileserver f3dfda90a..ddeb9bd6d:
  > Add CODEOWNERS file in preparation for branch protection rules (#8)
Submodule src/code.cloudfoundry.org/healthcheck ba40fd720..6587beaf1:
  > Add CODEOWNERS file in preparation for branch protection rules (#10)
Submodule src/code.cloudfoundry.org/inigo 8e5bf0cc7..b300679e6:
  > Add CODEOWNERS file in preparation for branch protection rules (#27)
Submodule src/code.cloudfoundry.org/localdriver bfbf40217..6d5a2bf56:
  > Add CODEOWNERS file in preparation for branch protection rules (#3)
Submodule src/code.cloudfoundry.org/locket 6cd541649..08e003863:
  > Add CODEOWNERS file in preparation for branch protection rules (#15)
Submodule src/code.cloudfoundry.org/operationq 4522d0860..b625ea3c1:
  > Add CODEOWNERS file in preparation for branch protection rules (#3)
Submodule src/code.cloudfoundry.org/rep 8550a6340..192ca3a5a:
  > Add CODEOWNERS file in preparation for branch protection rules (#43)
Submodule src/code.cloudfoundry.org/route-emitter b5abb628c..a17e814f0:
  > Add CODEOWNERS file in preparation for branch protection rules (#25)
Submodule src/code.cloudfoundry.org/routing-api 9592985dc..b9e9e0b90:
  > Add CODEOWNERS file in preparation for branch protection rules
Submodule src/code.cloudfoundry.org/routing-info c6998d604..079a27345:
  > Add CODEOWNERS file in preparation for branch protection rules
Submodule src/code.cloudfoundry.org/systemcerts 221d6f2ae..10f68b45f:
  > Add CODEOWNERS file in preparation for branch protection rules (#2)
Submodule src/code.cloudfoundry.org/vizzini 906e23011..5a2ef7822:
  > Add CODEOWNERS file in preparation for branch protection rules (#6)
Submodule src/code.cloudfoundry.org/volman 76091d503..b60663cd4:
  > Add CODEOWNERS file in preparation for branch protection rules (#6)
Submodule src/code.cloudfoundry.org/workpool 2e26d5d93..b93da105e:
  > Add CODEOWNERS file in preparation for branch protection rules (#3)
Submodule src/garden ac53c57dc..2d96d2498:
  > Bump lager to v3.0.2
  > Update go.mod dependencies
Submodule src/grootfs 9ea0d4bb9..f8dceb408:
  > Bump lager to v3.0.2
  > Update go.mod dependencies
  > Merge pull request #217 from geofffranks/main
Submodule src/guardian fac28108a..809884ce5:
  > Bump lager to v3.0.2
  > Update go.mod dependencies
  > Merge pull request #402 from geofffranks/main
Submodule src/idmapper a41052025..39b35b84a:
  > Merge pull request #71 from geofffranks/main
tas-runtime-bot pushed a commit that referenced this issue Feb 13, 2024
bump bbs credhub-cli garden grootfs guardian idmapper
f6b8c94 
Submodule src/code.cloudfoundry.org/bbs 0007fcda7..6d10e764f:
  > Remove cpu_weight limits (#81)
Submodule src/code.cloudfoundry.org/credhub-cli 99bf35c6e..22409e022:
  > Bump go modules
Submodule src/garden 790eb30a0..ed90b805c:
  > Update go.mod dependencies
Submodule src/grootfs 03565ddca..6ba496d33:
  > Update go.mod dependencies
  > Update go.mod dependencies
  > Update go.mod dependencies
  > Update go.mod dependencies
  > Update go.mod dependencies
Submodule src/guardian d2d353cba..81dfa3cb2:
  > Update go.mod dependencies
  > Update go.mod dependencies
  > Fix windows version for guardiancmd
  > Update go.mod dependencies
  > Pin gosigar to 1.3.45 until go is bumped to 1.22
  > Fix nerd_linux_test
  > Merge pull request #429 from cloudfoundry/unkillable-container-visibility
  > Update go.mod dependencies
  > Update go.mod dependencies
  > Bump go-jose to 3.0.1 for GHSA-2c7c-3mj9-8fqh
Submodule src/idmapper d9221be6a..e7b059893:
  > Update go.mod dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ramelito @cf-gitbot @emalm