Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue with special character in client secret #10

Closed
strehle opened this issue Jul 19, 2018 · 1 comment
Closed

issue with special character in client secret #10

strehle opened this issue Jul 19, 2018 · 1 comment
Labels
wontfix This will not be worked on

Comments

@strehle
Copy link
Member

strehle commented Jul 19, 2018

go-uaa uses oauth2 from standard go and this encodes authorization header according to standard
RFC, see
https://github.com/golang/oauth2/blob/master/internal/token.go#L195

However UAA as backend server does not handle this encoding, see existing issue on
cloudfoundry/uaa#778

I would like to have a direction for a fix, means, use non RFC complient encoding in go-uaa (uaa-cli) or fix UAA .
Problem now it, that uaa-cli (client) and uaa (server) are not working together if special characters in secret

e.g.
client_id: admin
client_secret: admin#secret

@joefitzgerald
Copy link
Contributor

I think using standard / RFC compliant encoding is appropriate, so I'm going to close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants