This repository has been archived by the owner on Jan 24, 2023. It is now read-only.
Service tags #1252
Merged
Service tags #1252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richard-cox
suggested changes
Sep 18, 2017
There was a problem hiding this comment.
Had a quick look pre-update
- There's a focus issue when clicking on the tags input box (the field shows a blue focus border briefly).
- The tags might look better with a 2px top/bottom margin on tag-item
- Think this was brought up at some point, but if possible we should show the tags on the app service instance tab and the cf space service instance tab
richard-cox
approved these changes
Sep 19, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.