Configurable backend log level #2533
Conversation
irfanhabib
commented
Jun 27, 2018
•
irfanhabib
commented
- Allows user to set the log level of the Jetstream
- Enables debug logging in docker-compose deployment
|
Hey irfanhabib! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
Codecov Report
@@ Coverage Diff @@
## v2-master #2533 +/- ##
==========================================
Coverage 70.44% 70.44%
==========================================
Files 594 594
Lines 25124 25124
Branches 5671 5671
==========================================
Hits 17698 17698
Misses 7426 7426 |
| @@ -159,6 +159,10 @@ spec: | |||
| {{- if .Values.socksProxy }} | |||
| value: {{.Values.socksProxy}} | |||
| {{- end }} | |||
| - name: LOG_LEVEL | |||
There was a problem hiding this comment.
Shouldn't the name be inside the if?
There was a problem hiding this comment.
The default value specified is info, if that is unset, we will still default to 'info'.
deploy/proxy.env
Outdated
| @@ -21,3 +21,4 @@ SESSION_STORE_SECRET=wheeee! | |||
| CONSOLE_PROXY_CERT_KEY=use local dev-cert/pproxy.key in portal-proxy repo | |||
| CONSOLE_PROXY_CERT=use local dev-cert/pproxy.crt in portal-proxy repo | |||
| ENCRYPTION_KEY=B374A26A71490437AA024E4FADD5B497FDFF1A8EA6FF12F6FB65AF2720B59CCF | |||
| LOG_LEVEL=debug | |||
There was a problem hiding this comment.
This will mean any docker compose deployment will have debug logging. Probably want to set this to info.
Should look to see if we can pass this as an env when running standupdevenv
There was a problem hiding this comment.
That was the intent, since docker-compose environments are dev environments. I'll move this to the standupdevenv and restart-proxy script.
