This repository has been archived by the owner on Jan 24, 2023. It is now read-only.
Update tokens table to fix issue affecting upgrades
#2544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey irfanhabib! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
Codecov Report
@@ Coverage Diff @@
## v2-master #2544 +/- ##
==========================================
Coverage 70.42% 70.42%
==========================================
Files 594 594
Lines 25132 25132
Branches 5674 5674
==========================================
Hits 17698 17698
Misses 7434 7434 |
nwmac
reviewed
Jun 27, 2018
| @@ -161,7 +161,7 @@ func (p *PgsqlTokenRepository) FindAuthToken(userGUID string, encryptionKey []by | |||
| err := p.db.QueryRow(findAuthToken, userGUID).Scan(&ciphertextAuthToken, &ciphertextRefreshToken, &tokenExpiry) | |||
| if err != nil { | |||
| msg := "Unable to Find UAA token: %v" | |||
| log.Debugf(msg, err) | |||
| log.Errorf(msg, err) | |||
There was a problem hiding this comment.
I think this needs to stay Debugf, otherwise verifySession without a valid session logs this every time
- the error handling in this case should be handled a level up in the code.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based off #2533
Fixes #2527