This repository has been archived by the owner on Jan 24, 2023. It is now read-only.
Ensure we don't recursively delete with the action is an update #2620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey KlapTrap! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
Codecov Report
@@ Coverage Diff @@
## v2-master #2620 +/- ##
=============================================
- Coverage 69.97% 69.92% -0.05%
=============================================
Files 595 596 +1
Lines 25235 25289 +54
Branches 5700 5716 +16
=============================================
+ Hits 17657 17684 +27
- Misses 7578 7605 +27 |
irfanhabib
suggested changes
Jul 4, 2018
| @@ -508,5 +508,8 @@ export class APIEffect { | |||
| } | |||
| } | |||
| } | |||
| private shouldRecusivlyDelete(requestType: string, apiAction: ICFAction) { | |||
| return requestType === 'delete' && !apiAction.updatingKey; | |||
There was a problem hiding this comment.
Method name has a typo.. should be shouldRecursivelyDelete
|
LGTM |
irfanhabib
approved these changes
Jul 4, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2608
Fixes #2623