Skip to content
This repository has been archived by the owner on Jan 24, 2023. It is now read-only.

Delete App Stepper: Disable delete of routes and services that are bound to other app/s #3129

Merged
merged 4 commits into from
Oct 30, 2018
Merged

Delete App Stepper: Disable delete of routes and services that are bound to other app/s #3129

merged 4 commits into from
Oct 30, 2018

Conversation

richard-cox
Copy link
Contributor

@richard-cox richard-cox commented Oct 16, 2018 •
edited
Loading

Also

  • Delete app - fixed cancel of stepper on fresh load
  • Delete app - final confirm step - Allow first columns to grow whilst still keeping some alignment. This gives specifically the route more space
  • Lots of imports/unused code tidy ups

@richard-cox
- Delete app - doubled size of space available for route
a3172e1 
- Delete app - fixed cancel of stepper on fresh load
- Lots of tidy ups
@richard-cox
Delete App Stepper: Disable delete of routes and services that are bo…
5b02fb8 
…und to other app/s

- Wire in disabled state to table checkbox
- Create disabled checkbox tooltip
- Handle 'select all' checkbox with disabled checkboxes. Alternatively we can remove the 'select all' checkbox if some are disabled
@richard-cox
Tweaks to delete app final step tables
dc3c42e 
- Allow first columns to grow whilst still keeping some alignment
@richard-cox richard-cox self-assigned this Oct 16, 2018
@cfdreddbot
Copy link

Hey richard-cox!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@codecov
Copy link

codecov bot commented Oct 16, 2018 •
edited
Loading

Codecov Report

Merging #3129 into v2-master will decrease coverage by 0.04%.
The diff coverage is 86.88%.

@@              Coverage Diff              @@
##           v2-master    #3129      +/-   ##
=============================================
- Coverage      71.16%   71.12%   -0.05%     
=============================================
  Files            627      627              
  Lines          27407    27400       -7     
  Branches        6229     6226       -3     
=============================================
- Hits           19504    19487      -17     
- Misses          7903     7913      +10

@richard-cox richard-cox added the community Community Raised Issue label Oct 24, 2018
nwmac
nwmac approved these changes Oct 30, 2018
View reviewed changes
Copy link
Contributor

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwmac nwmac merged commit c73f7bb into v2-master Oct 30, 2018
@nwmac nwmac deleted the delete-app-safeguards branch October 30, 2018 12:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nwmac nwmac nwmac approved these changes

Assignees

@richard-cox richard-cox

Labels
community Community Raised Issue ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Usability: Deletion of an app should not allow deletion of "shared" routes and services
3 participants
@richard-cox @cfdreddbot @nwmac