Skip to content
This repository has been archived by the owner on Jan 24, 2023. It is now read-only.

Add service plan list to service pages #3275

Merged
merged 11 commits into from
Jan 8, 2019
Merged

Add service plan list to service pages #3275

merged 11 commits into from
Jan 8, 2019

Conversation

richard-cox
Copy link
Contributor

@richard-cox richard-cox commented Dec 10, 2018

  • Add service plan tab containing service plan list to service pages
  • Fixed issue where space scoped services were incorrectly showing 'not visible' (wired in service broker)
  • Refactored common code in services service and create instance service, now in a common helper file
  • Commented out a lot of unused code in services service. Leaving this in for a few iterations until we're sure it's not needed
  • fixes Enable viewing/comparing service plan details without starting to create an instance #3078
  • Note... service plan costs can be tested by tweaking the following
 export const populateServicePlanExtraTyped = (servicePlan: APIResource<IServicePlan>): APIResource<IServicePlan> => {
   if (servicePlan.entity.extraTyped) {
     return servicePlan;
   }
+
+  servicePlan.entity.free = false;
+  servicePlan.entity.extra = JSON.stringify({
+    costs: [
+      {
+        'amount': {
+          'usd': 99.0
+        },
+        'unit': 'MONTHLY'
+      },
+      {
+        'amount': {
+          'usd': 0.99
+        },
+        'unit': '1GB of messages over 20GB'
+      }
+    ]
+  });

@cfdreddbot
Copy link

✅ Hey richard-cox! The commit authors and yourself have already signed the CLA.

- Add service plan tab containing service plan list to service pages
- Fixed issue where space scoped services were incorrectly showing 'not visible' (wired in service broker)
- Refactored common code in services service and create instance service, now in a common helper file
- Commented out a lot of unused code in services service. Leaving this in for a few iterations until we're sure it's not needed
- fixes #3078
@codecov
Copy link

codecov bot commented Dec 13, 2018

Codecov Report

Merging #3275 into v2-master will increase coverage by 0.21%.
The diff coverage is 75.92%.

@@              Coverage Diff              @@
##           v2-master    #3275      +/-   ##
=============================================
+ Coverage      70.85%   71.06%   +0.21%     
=============================================
  Files            642      649       +7     
  Lines          28323    28520     +197     
  Branches        6441     6504      +63     
=============================================
+ Hits           20067    20269     +202     
+ Misses          8256     8251       -5

@richard-cox richard-cox added the needs attention This PR needs attention label Dec 13, 2018
@richard-cox richard-cox removed the needs attention This PR needs attention label Dec 17, 2018
@richard-cox richard-cox added needs attention This PR needs attention and removed ready for review labels Jan 7, 2019
@richard-cox
Copy link
Contributor Author

  • Merge issues
  • Plan costs issue

@richard-cox richard-cox added ready for review and removed needs attention This PR needs attention labels Jan 7, 2019
Copy link
Contributor

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwmac nwmac merged commit 37bd86c into v2-master Jan 8, 2019
@nwmac nwmac deleted the service-plan-list branch January 8, 2019 11:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable viewing/comparing service plan details without starting to create an instance
3 participants