-
Notifications
You must be signed in to change notification settings - Fork 131
Conversation
richard-cox
commented
Mar 5, 2019
- depends on Fix exception thrown on home page #3420
- Add card view to the endpoints list, including endpoint type icon
- Move endpoint specific fields, like cf username and admin bool, into custom 'details' step
✅ Hey richard-cox! The commit authors and yourself have already signed the CLA. |
Codecov Report
@@ Coverage Diff @@
## v2-master #3422 +/- ##
==============================================
- Coverage 51.69% 25.95% -25.75%
==============================================
Files 678 682 +4
Lines 18620 18711 +91
Branches 3242 3258 +16
==============================================
- Hits 9626 4856 -4770
- Misses 8994 13855 +4861 |
- There may be other places where this magically worked and now correctly won't
@@ -2,6 +2,9 @@ import { Type } from '@angular/core'; | |||
import { FormGroup } from '@angular/forms'; | |||
import { Schema, schema } from 'normalizr'; | |||
|
|||
import { EndpointModel } from '../../../../store/src/types/endpoint.types'; | |||
import { TableCellCustom } from '../../shared/components/list/list.types'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The intent with the extensions folder/package was that it should not import anything else in the Stratos code base - thus it could be a separate package and extensions would only need to import the extensions package - they would not need to import anything else.
Is there a way to loosen the typing on listDetailsComponent and check it at runtime for compatibility?
if (!this.cell) { | ||
const componentFactory = this.componentFactoryResolver.resolveComponentFactory(e.listDetailsComponent); | ||
const componentRef = this.target.createComponent(componentFactory); | ||
this.cell = componentRef.instance as TableCellCustom<EndpointModel>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need a destroy function to clear this custom component up when this component is destroyed.
- Ensure extensions/extension-types.ts remains free from other imports - Now check endpoint detail type is correct at runtime - Cf Endpoint Type is now registered in cf package - Ensure cf package tests & lint execute correctly - Ensure endpoint details components are destroyed correctly
650988a
to
0b457fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM