Skip to content
This repository has been archived by the owner on Jan 24, 2023. It is now read-only.

When no space quota has been assigned fall back on more realistive quota #3541

Merged
merged 2 commits into from
Apr 30, 2019

Conversation

richard-cox
Copy link
Contributor

@richard-cox richard-cox commented Apr 29, 2019

- before, if no space quota was found, a rough match for the default quota was used
- this missed the `paid service plan` property
- now, before falling back on the 'infinite' quota, try to use the more realistive org quota
@cfdreddbot
Copy link

✅ Hey richard-cox! The commit authors and yourself have already signed the CLA.

@codecov
Copy link

codecov bot commented Apr 29, 2019

Codecov Report

Merging #3541 into v2-master will increase coverage by 0.01%.
The diff coverage is 41.17%.

@@              Coverage Diff              @@
##           v2-master    #3541      +/-   ##
=============================================
+ Coverage      51.76%   51.77%   +0.01%     
=============================================
  Files            720      720              
  Lines          20199    20204       +5     
  Branches        3604     3607       +3     
=============================================
+ Hits           10456    10461       +5     
  Misses          9743     9743

Copy link
Contributor

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwmac nwmac merged commit 36e43a3 into v2-master Apr 30, 2019
@nwmac nwmac deleted the fix-space-quota branch April 30, 2019 09:22
KlapTrap added a commit that referenced this pull request Apr 30, 2019
* v2-master: (722 commits)
  When no space quota has been assigned fall back on more realistive quota (#3541)
  Fix three user provided service create/edit stepper bugs (#3545)
  Fix SSO connect button not enabled
  Return default unknown endpoint type (#3517)
  Metrics chart is in the SUSE repository
  Ensure we have docker registry variables
  Fix registry change
  Final change
  Fix nav icon
  Ensure PR uses new branch
  Last fix
  Remove upstream specific #4
  Add helm chart PR creation
  Remove upstream specific #3
  Remove upstream specific #2
  Remove upstream specific #1
  Tweak side nav icon padding to align with tabs header
  Don't log key
  Fix upload of helm chart
  More tweaks
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Space summary: Provision Paid status showing as unknown
3 participants