Fix three user provided service create/edit stepper bugs #3545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
richard-cox
commented
Apr 29, 2019
•
richard-cox
commented
- Stepper/Navigation
- Previously the user couldn't return to the 'specify service details' step after going back to the 'select cf/org/space' step. This has now been fixed. Issue revolved around a guard in place to ensure navigation only happens after we've fetched the apps. This caused the onNext process to just wait forever - fixes User provided service instance: Create: Cannot return to details step #3543
- when arriving at the 'specify service details` step we were calling a non-existent onEnter
- 'specify service details' step - when editing
- We now correctly allow next once the tags are changed
- We now only allow next if the values have changed
- current implementation was put in place to ensure skipApps$ resolves before we continue to the next step - there was a bug where if user returns to step then continues again, as nothing had changed, onNext would never resolve - now move appsEmitted to more core observable
|
✅ Hey richard-cox! The commit authors and yourself have already signed the CLA. |
Codecov Report
@@ Coverage Diff @@
## v2-master #3545 +/- ##
=============================================
- Coverage 51.76% 51.75% -0.02%
=============================================
Files 720 720
Lines 20201 20217 +16
Branches 3605 3610 +5
=============================================
+ Hits 10458 10463 +5
- Misses 9743 9754 +11 |
KlapTrap
added a commit
that referenced
this pull request
Apr 30, 2019
* v2-master: (722 commits) When no space quota has been assigned fall back on more realistive quota (#3541) Fix three user provided service create/edit stepper bugs (#3545) Fix SSO connect button not enabled Return default unknown endpoint type (#3517) Metrics chart is in the SUSE repository Ensure we have docker registry variables Fix registry change Final change Fix nav icon Ensure PR uses new branch Last fix Remove upstream specific #4 Add helm chart PR creation Remove upstream specific #3 Remove upstream specific #2 Remove upstream specific #1 Tweak side nav icon padding to align with tabs header Don't log key Fix upload of helm chart More tweaks ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.