Skip to content
This repository has been archived by the owner on Jan 24, 2023. It is now read-only.

Fix connect to IBM Cloud #3715

Merged
merged 1 commit into from
Jul 17, 2019
Merged

Fix connect to IBM Cloud #3715

merged 1 commit into from
Jul 17, 2019

Conversation

richard-cox
Copy link
Contributor

@richard-cox
Fix connect to IBM Cloud
39f88aa 
- Ensure we use the AuthorizationEndpoint when fetching initial token
- This was recently changed in #3635
  - The PR covered what we expect to be a fix to SSO/cf push for CFs where token and auth endpoints differ
  - It changed FetchOAuth2Token which is not used in cf push world
  - Change broke cf push connect to IBM
  - Fix is to revert the change made at only this place
- More info can be found at..
  - https://docs.cloudfoundry.org/api/uaa/version/4.31.0/index.html#password-grant
  - https://tools.ietf.org/html/rfc6749#section-3.2
@richard-cox richard-cox requested a review from nwmac July 16, 2019 11:05
@richard-cox richard-cox self-assigned this Jul 16, 2019
@cfdreddbot
Copy link

✅ Hey richard-cox! The commit authors and yourself have already signed the CLA.

@codecov
Copy link

codecov bot commented Jul 16, 2019

Codecov Report

Merging #3715 into v2-master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           v2-master   #3715   +/-   ##
=========================================
  Coverage       51.4%   51.4%           
=========================================
  Files            726     726           
  Lines          20593   20593           
  Branches        3687    3687           
=========================================
  Hits           10585   10585           
  Misses         10008   10008

@richard-cox richard-cox mentioned this pull request Jul 16, 2019
Merged
nwmac
nwmac approved these changes Jul 17, 2019
View reviewed changes
Copy link
Contributor

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwmac nwmac merged commit 1795266 into v2-master Jul 17, 2019
@nwmac nwmac deleted the fix-ibm-connect branch July 17, 2019 11:51
KlapTrap added a commit that referenced this pull request Jul 26, 2019
@KlapTrap
Merge remote-tracking branch 'origin/entity-catalogue-store' into sto…
89cf684 
…re-cf-reducers

* origin/entity-catalogue-store: (196 commits)
  Remove console log
  Fix forever waiting waitForCFPermissions - seen in ibm endpoint causing users & other stats to not load (org card details)
  Fix orgSpacePostProcess
  Fix autoscaler compile errors
  Non-autoscaler fixes
  Fix persist of dashboard settings - side nav will now retain out/in state - added additional logging
  Tidy up some styling - Ensure autoscaller tiles take up full width when page is shrunk horizontally - position of polling indicator on recent apps - app-tile margin removed from top and added to bottom (fixes app/cf summary pages) - added min height to latest metrics card to avoid vertical wibble on refresh
  [autoscaler] using app-polling-indicator to replace refresh-icon
  Fix syntax error
  Fix unit tests
  Add app polling controller (#3683)
  Fix connect to IBM Cloud (#3715)
  Additional invite user logging and nav changes (#3716)
  Update package lock
  Ensure user invites template path is set
  Ensure both private and shared domains are included in domain lists (#3695)
  Fix typo in file path
  Ensuer user invite templates are included in the image
  Fix e2e tests when running against a UAA with no explicit zone (cfdev) (#3713)
  Add logging
  ...
KlapTrap added a commit that referenced this pull request Jul 26, 2019
@KlapTrap
Merge branch 'entity-catalogue-store' into store-cf-reducers2
d54956c 
* entity-catalogue-store: (196 commits)
  Improve disable polling messaging
  Remove console log
  Fix forever waiting waitForCFPermissions - seen in ibm endpoint causing users & other stats to not load (org card details)
  Fix orgSpacePostProcess
  Fix autoscaler compile errors
  Non-autoscaler fixes
  Tidy up some styling - Ensure autoscaller tiles take up full width when page is shrunk horizontally - position of polling indicator on recent apps - app-tile margin removed from top and added to bottom (fixes app/cf summary pages) - added min height to latest metrics card to avoid vertical wibble on refresh
  [autoscaler] using app-polling-indicator to replace refresh-icon
  Fix syntax error
  Fix unit tests
  Add app polling controller (#3683)
  Fix connect to IBM Cloud (#3715)
  Additional invite user logging and nav changes (#3716)
  Update package lock
  Ensure user invites template path is set
  Ensure both private and shared domains are included in domain lists (#3695)
  Fix typo in file path
  Ensuer user invite templates are included in the image
  Fix e2e tests when running against a UAA with no explicit zone (cfdev) (#3713)
  Add logging
  ...
KlapTrap added a commit that referenced this pull request Jul 26, 2019
@KlapTrap
Merge branch 'entity-catalogue-store' into store-cf-reducers3
7adbcf3 
* entity-catalogue-store: (197 commits)
  Fix imports
  Improve disable polling messaging
  Remove console log
  Fix forever waiting waitForCFPermissions - seen in ibm endpoint causing users & other stats to not load (org card details)
  Fix orgSpacePostProcess
  Fix autoscaler compile errors
  Non-autoscaler fixes
  Tidy up some styling - Ensure autoscaller tiles take up full width when page is shrunk horizontally - position of polling indicator on recent apps - app-tile margin removed from top and added to bottom (fixes app/cf summary pages) - added min height to latest metrics card to avoid vertical wibble on refresh
  [autoscaler] using app-polling-indicator to replace refresh-icon
  Fix syntax error
  Fix unit tests
  Add app polling controller (#3683)
  Fix connect to IBM Cloud (#3715)
  Additional invite user logging and nav changes (#3716)
  Update package lock
  Ensure user invites template path is set
  Ensure both private and shared domains are included in domain lists (#3695)
  Fix typo in file path
  Ensuer user invite templates are included in the image
  Fix e2e tests when running against a UAA with no explicit zone (cfdev) (#3713)
  ...
KlapTrap added a commit that referenced this pull request Jul 26, 2019
@KlapTrap
Merge branch 'entity-catalogue-store' into store-cf-types
d37cc79 
* entity-catalogue-store: (197 commits)
  Fix imports
  Improve disable polling messaging
  Remove console log
  Fix forever waiting waitForCFPermissions - seen in ibm endpoint causing users & other stats to not load (org card details)
  Fix orgSpacePostProcess
  Fix autoscaler compile errors
  Non-autoscaler fixes
  Tidy up some styling - Ensure autoscaller tiles take up full width when page is shrunk horizontally - position of polling indicator on recent apps - app-tile margin removed from top and added to bottom (fixes app/cf summary pages) - added min height to latest metrics card to avoid vertical wibble on refresh
  [autoscaler] using app-polling-indicator to replace refresh-icon
  Fix syntax error
  Fix unit tests
  Add app polling controller (#3683)
  Fix connect to IBM Cloud (#3715)
  Additional invite user logging and nav changes (#3716)
  Update package lock
  Ensure user invites template path is set
  Ensure both private and shared domains are included in domain lists (#3695)
  Fix typo in file path
  Ensuer user invite templates are included in the image
  Fix e2e tests when running against a UAA with no explicit zone (cfdev) (#3713)
  ...
KlapTrap added a commit that referenced this pull request Jul 26, 2019
@KlapTrap
Merge branch 'entity-catalogue-store' into store-cf-types2
bb42734 
* entity-catalogue-store: (201 commits)
  Remove test file
  Merge fixes
  Fix imports
  Improve disable polling messaging
  Remove console log
  Fix forever waiting waitForCFPermissions - seen in ibm endpoint causing users & other stats to not load (org card details)
  Fix orgSpacePostProcess
  Fix autoscaler compile errors
  Non-autoscaler fixes
  Final round of identifying (and fixing minor) todos
  WIP
  Tidy up some styling - Ensure autoscaller tiles take up full width when page is shrunk horizontally - position of polling indicator on recent apps - app-tile margin removed from top and added to bottom (fixes app/cf summary pages) - added min height to latest metrics card to avoid vertical wibble on refresh
  [autoscaler] using app-polling-indicator to replace refresh-icon
  Fix syntax error
  Fix unit tests
  Add app polling controller (#3683)
  Fix connect to IBM Cloud (#3715)
  Additional invite user logging and nav changes (#3716)
  Update package lock
  Ensure user invites template path is set
  ...
KlapTrap added a commit that referenced this pull request Jul 26, 2019
@KlapTrap
Merge branch 'entity-catalogue-store' into store-cf-next-round
24cd048 
* entity-catalogue-store: (202 commits)
  Fix autoscaler import
  Remove test file
  Merge fixes
  Fix imports
  Improve disable polling messaging
  Remove console log
  Fix forever waiting waitForCFPermissions - seen in ibm endpoint causing users & other stats to not load (org card details)
  Fix orgSpacePostProcess
  Fix autoscaler compile errors
  Non-autoscaler fixes
  Final round of identifying (and fixing minor) todos
  WIP
  Tidy up some styling - Ensure autoscaller tiles take up full width when page is shrunk horizontally - position of polling indicator on recent apps - app-tile margin removed from top and added to bottom (fixes app/cf summary pages) - added min height to latest metrics card to avoid vertical wibble on refresh
  [autoscaler] using app-polling-indicator to replace refresh-icon
  Fix syntax error
  Fix unit tests
  Add app polling controller (#3683)
  Fix connect to IBM Cloud (#3715)
  Additional invite user logging and nav changes (#3716)
  Update package lock
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nwmac nwmac nwmac approved these changes

Assignees

@richard-cox richard-cox

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@richard-cox @cfdreddbot @nwmac