Add Application Autoscaler Tab

[richard-cox]

See #3266 for additional history

[cfdreddbot]

✅ Hey richard-cox! The commit authors and yourself have already signed the CLA.

[richard-cox]

Not quite made it through yet, but here's a few very minor non-functional suggestions

[richard-cox]

Along with inline comments there's some general things, all are minor and I don't think need to be done for the demo.

Autoscaler Tab

• Refresh on slower loading connections and the policy slider in status is shown. This should be hidden as the rest See LoadingPageComponent appears underneath content with z-index > 0 #3509
• The status card shows a 'policy' slider with text 'Policy undefined' or 'Policy defined'. Think this text should just be 'Enabled' and 'Disabled' for the two states 78405f3
• Latest Events Card
  • When there are no events we should probably not show the link in the bottom right 78405f3
  • The position of the link button appears over the table when there's no time based rules 78405f3
• Scheduled Limit Rules Card
  • The position of the edit button appears over the table when there's no time based rules 78405f3

AutoScaler Metric Charts Modal

• On first load the chart flashes three or four times. I think this could be a recent change we made that means observable chains on entities fire more often. I'm looking into this

Edit AutoScaler Policy Stepper

• Scaling Rules, Recurring Schedules and Specific Dates steps
  • I think we need to bring the 'Add' button up from the stepper controls to the same context as the list of rules. Something like an 'add' material icon with the text 'Add' in a button bottom left of the list would look good. d0ca5f6
• Specific Dates Step
  • On clicking finish
    • Success - User should be taken back to the Autoscaler tab. Think you can do this by setting redirect: true in the StepOnNextResult returned by the step onNext function d141f1d
    • Failure - the onNext function should return { success: false, message: ''}. That will show the error in a snackbar at the bottom of the screen instead of in the main context d141f1d

[KlapTrap]

I'm a little nervous about the small amount of FE & BE unit tests. Unit tests are even more important when we don't own the code, it would really help us out when maintaining our codebase in the future.

[KlapTrap]

Why do we need to add an entry to the stratosNavigation here?

[zyjiaobj]

Do you mean to remove the below code?

    data: {
      stratosNavigation: {
        text: 'Applications',
        matIcon: 'apps',
        position: 20,
        hidden: of(true)
      }
    },

But when i remove this part of code, the https://localhost:4200/autoscaler/b5F2dF-Qr-r7yNWeDya0GTOL09c/2369e308-0733-40ce-ae9e-ed85fdbcca40/edit-autoscaler-policy and other autoscaler paths will failed to load with 404 error.
I don't know why... Could you please help me check? @richard-cox @KlapTrap

[KlapTrap]

Yeah, that's what I thought. I think it would be worth rich and I taking a look and seeing what's going on, it doesn't seem right for you to have to do that!

[richard-cox]

I've resolved the merge conflicts by bringing in v2-master. This has brought with it a change that breaks connecting to IBM Cloud via the endpoints page (SSO/cf push works fine though). There's a PR up that will fix this - #3715. I'll work on getting this through the gates again