This repository has been archived by the owner on Jan 24, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 131
Typed access to actions and entities via catalog entity #4247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
richard-cox
commented
Apr 30, 2020
•
edited
Loading
edited
- Provide typed way to access the following via the catalog entity
- actions (and dispatch them),
- entity monitors/services
- pagination monitors/services
- Also
- fixes Profile: Disabling polling fails to disable polling #4244
- fixes Unbind services stepper fails to show bound services #4246
…itorFactory imports
…ice in edit space component)
richard-cox
commented
May 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments
...eatures/applications/application/application-tabs-base/tabs/build-tab/build-tab.component.ts
Outdated
Show resolved
Hide resolved
...oundry/src/features/cloud-foundry/add-space/create-space-step/create-space-step.component.ts
Show resolved
Hide resolved
...d-foundry/src/features/cloud-foundry/edit-space/edit-space-step/edit-space-step.component.ts
Outdated
Show resolved
Hide resolved
...d-foundry/src/features/cloud-foundry/edit-space/edit-space-step/edit-space-step.component.ts
Show resolved
Hide resolved
...st/list-types/cf-spaces-service-instances/table-cell-service/table-cell-service.component.ts
Show resolved
Hide resolved
src/frontend/packages/core/src/shared/services/cloud-foundry-user-provided-services.service.ts
Outdated
Show resolved
Hide resolved
src/frontend/packages/core/src/shared/services/cloud-foundry-user-provided-services.service.ts
Outdated
Show resolved
Hide resolved
src/frontend/packages/core/src/shared/services/cloud-foundry-user-provided-services.service.ts
Outdated
Show resolved
Hide resolved
...ckages/store/src/entity-catalog/entity-catalog-entity/entity-catalog-entity-store-helpers.ts
Show resolved
Hide resolved
richard-cox
commented
May 15, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments
src/frontend/packages/cloud-foundry/src/shared/data-services/service-action-helper.service.ts
Show resolved
Hide resolved
src/frontend/packages/core/src/shared/services/cloud-foundry-user-provided-services.service.ts
Outdated
Show resolved
Hide resolved
...ckages/store/src/entity-catalog/entity-catalog-entity/entity-catalog-entity-store-helpers.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.