Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typed access to actions and entities via catalog entity #377

Merged
merged 22 commits into from
Jun 16, 2020

Conversation

richard-cox
Copy link
Member

@richard-cox richard-cox commented May 15, 2020

@richard-cox richard-cox self-assigned this May 15, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jun 11, 2020

Codecov Report

Merging #377 into master will increase coverage by 0.03%.
The diff coverage is 79.33%.

@@            Coverage Diff             @@
##           master     #377      +/-   ##
==========================================
+ Coverage   59.37%   59.41%   +0.03%     
==========================================
  Files        1046     1052       +6     
  Lines       33076    33100      +24     
  Branches     4636     4636              
==========================================
+ Hits        19640    19665      +25     
+ Misses      13436    13435       -1     

@richard-cox richard-cox added the needs attention Needs attention label Jun 12, 2020
Copy link
Member Author

@richard-cox richard-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@richard-cox richard-cox removed the needs attention Needs attention label Jun 12, 2020
Copy link
Member

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwmac nwmac merged commit 5972a7a into master Jun 16, 2020
@nwmac nwmac deleted the merge-upstream-entity-access branch June 16, 2020 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants