forked from cloudfoundry/stratos
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typed access to actions and entities via catalog entity #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
richard-cox
commented
May 15, 2020
•
edited
Loading
edited
- apply new access features to kube, workload and helm types (see Typed access to actions and entities via catalog entity cloudfoundry/stratos#4247)
- blocked on Typed access to actions and entities via catalog entity cloudfoundry/stratos#4247 being merged downstream. See PR Merge upstream #378
…nto merge-upstream-entity-access
…nto merge-upstream-entity-access
…eam-entity-access
…eam-entity-access
…eam-entity-access
Codecov Report
@@ Coverage Diff @@
## master #377 +/- ##
==========================================
+ Coverage 59.37% 59.41% +0.03%
==========================================
Files 1046 1052 +6
Lines 33076 33100 +24
Branches 4636 4636
==========================================
+ Hits 19640 19665 +25
+ Misses 13436 13435 -1 |
richard-cox
commented
Jun 12, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments
custom-src/frontend/app/custom/helm/create-release/create-release.component.ts
Show resolved
Hide resolved
custom-src/frontend/app/custom/kubernetes/store/action-builders/kube.action-builders.ts
Outdated
Show resolved
Hide resolved
...frontend/app/custom/kubernetes/workloads/list-types/kube-namespaces-filter-config.service.ts
Outdated
Show resolved
Hide resolved
...custom/kubernetes/workloads/release/helm-release-tab-base/helm-release-tab-base.component.ts
Show resolved
Hide resolved
...custom/kubernetes/workloads/release/helm-release-tab-base/helm-release-tab-base.component.ts
Outdated
Show resolved
Hide resolved
custom-src/frontend/app/custom/kubernetes/workloads/release/tabs/helm-release-helper.service.ts
Outdated
Show resolved
Hide resolved
custom-src/frontend/app/custom/kubernetes/workloads/workloads-entity-catalog.ts
Outdated
Show resolved
Hide resolved
.../core/src/features/endpoints/backup-restore/backup-endpoints/backup-endpoints.component.html
Show resolved
Hide resolved
nwmac
approved these changes
Jun 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.