This repository has been archived by the owner on Jan 24, 2023. It is now read-only.
update kubernetes deploy doc to reference uaa.endpoint #4307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noticed that in this commit which updates the stratos console uaa configuration to be simpler and leverage "uaa.endpoint" that the README was using an example referencing "uaa.url" (which I don't think is a param reference? could be wrong?) and still including uaa.port, uaa.host, etc., though it appears that was all replaced by `uaa.endpoint` no rush; would appreciate if someone double-checked this, I didn't completely confirm or test this, to be honest. I'll look more into it this evening after work. apologies if I'm dead wrong. thanks for the time
…console - bumps doc to point to 3.2.0 - fixes the `helm search` command to `helm repo search` (at least that's what it is for helm3?)
richard-cox
approved these changes
May 26, 2020
There was a problem hiding this comment.
Hi @aegershman , thanks for submitting this PR. Changes look good and I'm happy to merge. If you're good too please bring out of draft and I'll get it in.
richard-cox
approved these changes
May 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
note: I didn't follow the contributing guidelines yet, I'll fix it up after work hours today
noticed that in this commit which updates the stratos console uaa configuration to be simpler and leverage "uaa.endpoint" that the README was using an example referencing "uaa.url" (which I don't think is a param reference? could be wrong?) and still including uaa.port, uaa.host, etc., though it appears that was all replaced by
uaa.endpoint. would appreciate if someone double-checked this, apologies if I'm dead wrong.additionally:
helm repo search consolethanks for the time