Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump jasmine from 4.6.0 to 5.1.0 in /uaa #2417

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 24, 2023

Bumps jasmine from 4.6.0 to 5.1.0.

Release notes

Sourced from jasmine's releases.

5.1.0

Please see the release notes.

5.0.2

Please see the release notes.

5.0.1

Please see the release notes.

5.0.0

Please see the release notes.

5.0.0-beta.0

Please see the release notes.

5.0.0-alpha.1

Please see the release notes.

5.0.0-alpha.0

Please see the release notes.

Commits
  • eea8b26 Bump version to 5.1.0
  • 84eaef0 Issue a deprecation warning if both jasmine.js and jasmine.json are found
  • 882bd5a Clarify that ENOENT handling is potentially specific to Testdouble.js
  • 097bb29 Fixed support for importing namespaced modules e.g. @​serenity-js/jasmine
  • 2689181 Fixed config file detection when ES custom loaders (--loader=) are used
  • f678a08 Bump version to 5.0.2
  • 5f7b19b Fixed --require
  • d0b93c4 Bump version to 5.0.1
  • b35d0c8 Depend on main branch of core
  • 7214425 Fixed state leak between multiple Jasmine instances run consecutively
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Jul 24, 2023
@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/185676798

The labels on this github issue will be updated when the story is started.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 24, 2023

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/uaa/jasmine-5.1.0 branch July 24, 2023 19:24
@Tallicia
Copy link
Contributor

@dependabot reopen

@dependabot dependabot bot reopened this Jul 24, 2023
@dependabot dependabot bot restored the dependabot/npm_and_yarn/uaa/jasmine-5.1.0 branch July 24, 2023 19:48
@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/185681076

The labels on this github issue will be updated when the story is started.

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/uaa/jasmine-5.1.0 branch from 98c323a to c4b3d14 Compare July 24, 2023 19:48
@Tallicia
Copy link
Contributor

@dependabot rebase

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 24, 2023

Looks like this PR is already up-to-date with develop! If you'd still like to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@Tallicia
Copy link
Contributor

@dependabot recreate

Bumps [jasmine](https://github.com/jasmine/jasmine-npm) from 4.6.0 to 5.1.0.
- [Release notes](https://github.com/jasmine/jasmine-npm/releases)
- [Changelog](https://github.com/jasmine/jasmine-npm/blob/main/RELEASE.md)
- [Commits](jasmine/jasmine-npm@v4.6.0...v5.1.0)

---
updated-dependencies:
- dependency-name: jasmine
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/uaa/jasmine-5.1.0 branch from c4b3d14 to 6f4c22b Compare July 24, 2023 21:34
@Tallicia
Copy link
Contributor

The image this is running on is using node v12, it should be updated to 20 or 18 - uaa-singular is on 20 on jammy

`root@891233d6-3ffd-4e39-4697-1fe5b0355bc8:/tmp/build/9d457a1d/uaa# ./scripts/jasmine-tests.sh
+++ dirname ./scripts/jasmine-tests.sh
++ cd ./scripts
++ pwd

  • SCRIPT_DIR=/tmp/build/9d457a1d/uaa/scripts
  • pushd /tmp/build/9d457a1d/uaa/scripts/../uaa
    /tmp/build/9d457a1d/uaa/uaa /tmp/build/9d457a1d/uaa
  • npm install
    audited 43 packages in 0.621s

13 packages are looking for funding
run npm fund for details

found 0 vulnerabilities

  • npm test

server@1.0.0 test /tmp/build/9d457a1d/uaa/uaa
node_modules/jasmine/bin/jasmine.js --config=jasmine.json

/tmp/build/9d457a1d/uaa/uaa/node_modules/minimatch/dist/cjs/ast.js:86
#fillNegs() {
^

SyntaxError: Unexpected token '('
at wrapSafe (internal/modules/cjs/loader.js:915:16)
at Module._compile (internal/modules/cjs/loader.js:963:27)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)
at Module.load (internal/modules/cjs/loader.js:863:32)
at Function.Module._load (internal/modules/cjs/loader.js:708:14)
at Module.require (internal/modules/cjs/loader.js:887:19)
at require (internal/modules/cjs/helpers.js:74:18)
at Object. (/tmp/build/9d457a1d/uaa/uaa/node_modules/minimatch/dist/cjs/index.js:9:18)
at Module._compile (internal/modules/cjs/loader.js:999:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)
npm ERR! Test failed. See above for more details.
root@891233d6-3ffd-4e39-4697-1fe5b0355bc8:/tmp/build/9d457a1d/uaa# npm version
{
npm: '6.14.11',
ares: '1.16.1',
brotli: '1.0.9',
cldr: '37.0',
http_parser: '2.9.4',
icu: '67.1',
llhttp: '2.1.3',
modules: '72',
napi: '7',
nghttp2: '1.41.0',
node: '12.20.1',
openssl: '1.1.1i',
tz: '2019c',
unicode: '13.0',
uv: '1.40.0',
v8: '7.8.279.23-node.45',
zlib: '1.2.11'
}
root@891233d6-3ffd-4e39-4697-1fe5b0355bc8:/tmp/build/9d457a1d/uaa# node --version
v12.20.1`

@Tallicia
Copy link
Contributor

The test ran successfully with updated image here but I can not get the concourse-ci/status job to rerun.

@Tallicia Tallicia self-assigned this Jul 24, 2023
@Tallicia
Copy link
Contributor

I got it to run and it's looking good.

@Tallicia Tallicia merged commit 880b815 into develop Jul 24, 2023
20 checks passed
@Tallicia Tallicia deleted the dependabot/npm_and_yarn/uaa/jasmine-5.1.0 branch July 24, 2023 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants