Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump: Java version to 17 #2562

Merged
merged 3 commits into from
Oct 20, 2023
Merged

Conversation

peterhaochen47
Copy link
Member

  • build UAA with Java 17 (bumped from Java 11)
  • fails with error if built with Java version lower than 17

[#186054019]

- build UAA with Java 17 (bumped from Java 11)
- fails with error if built with Java version lower than 17

[#186054019]
@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/186295869

The labels on this github issue will be updated when the story is started.

- Remove Java 11 test on GitHub Actions
as UAA will no longer be built with Java 11 after this PR

[#186054019]
Copy link
Member

@strehle strehle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see inline

build.gradle Show resolved Hide resolved
@strehle strehle added this to the 76.24.0 milestone Oct 20, 2023
- to be more consistent with other places in this file
that uses constants to represent Java versions.

[#186054019]
build.gradle Outdated Show resolved Hide resolved
@strehle strehle requested review from torsten-sap and a team October 20, 2023 08:18
@strehle strehle added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Oct 20, 2023
Copy link
Contributor

@Tallicia Tallicia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good

@peterhaochen47 peterhaochen47 merged commit a11ad85 into develop Oct 20, 2023
20 checks passed
@peterhaochen47 peterhaochen47 deleted the pr/develop/build-with-java-17 branch October 20, 2023 16:26
peterhaochen47 added a commit that referenced this pull request Oct 20, 2023
- now that uaa has been bumped to Java 17
  (#2562), the README needs to
  reflect that

[#186054019]
peterhaochen47 added a commit that referenced this pull request Oct 21, 2023
- now that uaa has been bumped to Java 17
  (#2562), the README needs to
  reflect that

[#186054019]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants