Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump: Java version to 17 #2562

Merged
merged 3 commits into from
Oct 20, 2023
Merged

Bump: Java version to 17 #2562

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7bdadfb
Bump to Java 17
peterhaochen47 Oct 19, 2023
6065096
Remove unnecessary test on GitHub Actions
peterhaochen47 Oct 19, 2023
9269b64
refactor: use constants
peterhaochen47 Oct 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/gradle.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:
pull_request:
branches: [ develop ]

# Run job on CF landscape, e.g. ubuntu 1804 and bellsoft java 11
# Run job on CF landscape, e.g. ubuntu 1804 and bellsoft java 17
permissions:
contents: read

Expand All @@ -16,7 +16,7 @@ jobs:
strategy:
fail-fast: false
matrix:
java: [ '11', '17' ]
java: [ '17' ]
steps:
- uses: actions/checkout@v4
- uses: actions/setup-java@v3
Expand Down
8 changes: 4 additions & 4 deletions build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,8 @@ subprojects {

[compileJava, compileTestJava]*.options*.compilerArgs = ["-Xlint:none", "-nowarn"]

strehle marked this conversation as resolved.
Show resolved Hide resolved
sourceCompatibility = 1.11
targetCompatibility = 1.11
sourceCompatibility = JavaVersion.VERSION_17
targetCompatibility = JavaVersion.VERSION_17

test {
maxParallelForks = 1
Expand Down Expand Up @@ -159,8 +159,8 @@ cargo {
containerId = "tomcat9x"
port = applicationPort

if (JavaVersion.current() < JavaVersion.VERSION_11) {
throw new GradleException("This build must be run with Java version [ " + JavaVersion.VERSION_11 + " ] or greater. Your Java version is [ " + JavaVersion.current() + " ]")
if (JavaVersion.current() < JavaVersion.VERSION_17) {
throw new GradleException("This build must be run with Java version [ " + JavaVersion.VERSION_17 + " ] or greater. Your Java version is [ " + JavaVersion.current() + " ]")
}

deployable {
Expand Down