Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade spring security version 5.8.9 #2660

Merged
merged 3 commits into from
Dec 28, 2023
Merged

upgrade spring security version 5.8.9 #2660

merged 3 commits into from
Dec 28, 2023

Conversation

strehle
Copy link
Member

@strehle strehle commented Dec 27, 2023

define own spring framework and security versions
prepare for spring boot upgrade 3.x
@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/186743194

The labels on this github issue will be updated when the story is started.

@strehle strehle requested a review from a team December 27, 2023 10:31
@strehle strehle added dependencies Pull requests that update a dependency file java Pull requests that update Java code and removed unscheduled labels Dec 27, 2023
@peterhaochen47
Copy link
Member

Hi @strehle, I interpret this PR as doing the following 2 things:

  • allow us to explicitly define the versions of springframework and spring-security related libraries (before, it was just whatever versions springboot provides)
  • upgrade spring-security to 5.8.9.

Could you help me understand why these 2 changes are "[preparing] for spring boot upgrade 3.x"? Are we trying to upgrade spring-security before the springboot upgrade?

@strehle
Copy link
Member Author

strehle commented Dec 27, 2023

@peterhaochen47 yes, this PR includes #2659

Reason:

@peterhaochen47
Copy link
Member

peterhaochen47 commented Dec 27, 2023

@strehle I see. Makes sense. So #2659 would be a temporary measure, and after spring boot 3 upgrade we can reverse this refactor (since we'll be getting the spring security updates automatically from spring boot 3).

@strehle strehle merged commit 2cefee5 into develop Dec 28, 2023
20 checks passed
@strehle strehle deleted the updateSpringSecurity branch December 28, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
Development

Successfully merging this pull request may close these issues.

3 participants