remove more IdP tests #2742
Merged
remove more IdP tests #2742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This test covers IdP features that are no longer supported. [#187065237] Co-authored-by: Hongchol Sinn <hongchol.sinn@broadcom.com>
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/187093240 The labels on this github issue will be updated when the story is started. |
* When this test works, the discovery endpoint redirects to something like this: "http://uaa-acting-as-saml-proxy-zone-isq9kv.localhost:8080/uaa/saml/login/alias/uaa-acting-as-saml-pr[...]aml-idp-zone-bd8ptn.cloudfoundry-saml-login". * To keep the coverage for the part of the test that hits that "saml/login/alias" endpoint, we would need to rewrite it so that it doesn't depend on the SAML IdP features that were removed from UAA. We're deferring the decision to add this coverage back. [#187065237] Co-authored-by: Hongchol Sinn <hongchol.sinn@broadcom.com>
swalchemist
force-pushed
the
saml-idp-cleanup-187065237
branch
from
6194843
to
7c9d296
Compare
hsinn0
approved these changes
Feb 22, 2024
peterhaochen47
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the test cases was IDP test, so we removed. For the other test case, we considered modifying it to still be useful even now that the UAA IdP feature is removed, but we concluded that the potential usefulness of the tests isn't justified by the effort that would be required.
With @hsinn0.