Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove more IdP tests #2742

Merged
merged 2 commits into from
Feb 23, 2024
Merged

remove more IdP tests #2742

merged 2 commits into from
Feb 23, 2024

Commits on Feb 22, 2024

  1. delete: unused test 

    * This test covers IdP features that are no longer supported.

[#187065237]

Co-authored-by: Hongchol Sinn <hongchol.sinn@broadcom.com>
    @swalchemist @hsinn0
    swalchemist and hsinn0 committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    7dd538f View commit details
    Browse the repository at this point in the history

  2. delete: another unused test 

    * When this test works, the discovery endpoint redirects to something
  like this:
 "http://uaa-acting-as-saml-proxy-zone-isq9kv.localhost:8080/uaa/saml/login/alias/uaa-acting-as-saml-pr[...]aml-idp-zone-bd8ptn.cloudfoundry-saml-login".
* To keep the coverage for the part of the test that hits that
  "saml/login/alias" endpoint, we would need to rewrite it so that
  it doesn't depend on the SAML IdP features that were removed from
  UAA. We're deferring the decision to add this coverage back.

[#187065237]

Co-authored-by: Hongchol Sinn <hongchol.sinn@broadcom.com>
    @swalchemist @hsinn0
    swalchemist and hsinn0 committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    7c9d296 View commit details
    Browse the repository at this point in the history