-
Notifications
You must be signed in to change notification settings - Fork 826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sonar refactoring - IdentityProviderEndpoints class #2890
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
ede8431
Sonar refactorings
strehle c7774ea
remove dead code
strehle d1e706e
more sonar smell fixes
strehle 672b8d3
no log change
strehle 771bc91
revert and allow test endpoint again
strehle 2e2f04d
warnings
strehle 6d6b5c3
Merge remote-tracking branch 'refs/remotes/origin/develop' into refac…
strehle 441c13d
rebase
strehle a07632e
Merge remote-tracking branch 'refs/remotes/origin/develop' into refac…
strehle d7a1c35
rebase
strehle ae4a539
test setup
strehle 3d087dc
Merge remote-tracking branch 'refs/remotes/origin/develop' into refac…
strehle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this not end up returning different status for the same result after this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this part was a duplicated one, see
![image](https://private-user-images.githubusercontent.com/11627201/334155585-ac0cf835-a9e2-416e-8a7d-6ec0ce3691d4.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjYwODEyODAsIm5iZiI6MTcyNjA4MDk4MCwicGF0aCI6Ii8xMTYyNzIwMS8zMzQxNTU1ODUtYWMwY2Y4MzUtYTllMi00MTZlLThhN2QtNmVjMGNlMzY5MWQ0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MTElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTExVDE4NTYyMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWMzZjc0MTY3NGM2MDQ1YjY1ZTM4ZjIzNjA3ZWJhNmFiZjllZjRjN2Q4MjNiY2MzMjJhMjNjZmJiMDQ4NjA5OTgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.I7aPnrO-Ly0oaksruAtlHWQ7gld80QniFUp2gb8n7hA)
now an extra method persistIdentityProviderChange for create and update