Refactor: Load UserConfig as bean #2934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goal: identityZoneConfigurationBootstrap should not get to many attributes, but load the user config itself and allow there to have extra options Example: login.checkOriginEnabled is not yet possible to set in CF global because it is / was hidden in the identityZoneConfigurationBootstrap bean. With UserConfig bean allow all options to be configured. Open: uaa-release should be adopted as well
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/187815406 The labels on this github issue will be updated when the story is started. |
hsinn0
approved these changes
Jul 10, 2024
strehle
added a commit
to cloudfoundry/uaa-release
that referenced
this pull request
Jul 11, 2024
strehle
added a commit
to cloudfoundry/uaa-release
that referenced
this pull request
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal: identityZoneConfigurationBootstrap should not get to many attributes, but load the user config itself and allow there to have extra options
Example: login.checkOriginEnabled is not yet possible to set in CF global because it is / was hidden in the identityZoneConfigurationBootstrap bean. With UserConfig bean allow all options to be configured.
Open: uaa-release should be adopted as well