Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update to apps/v1 and add selector #759

Merged
merged 1 commit into from
Aug 1, 2019
Merged

update to apps/v1 and add selector #759

merged 1 commit into from
Aug 1, 2019

Conversation

MarkDeckert
Copy link
Contributor

Fixes #758

Also had to add a selector for this to work for me (k8s version 1.14.3)

@murali-reddy
Copy link
Member

@MarkDeckert thanks for the PR. apps/v1 change is obvious. Not sure why you need label selector. What error you are running into if dont add it?

@MarkDeckert
Copy link
Contributor Author

Without selector:

$ kubectl apply -f kubeadm-kuberouter-all-features.yaml
configmap/kube-router-cfg unchanged
error: error validating "kubeadm-kuberouter-all-features.yaml": error validating data: ValidationError(DaemonSet.spec): missing required field "selector" in io.k8s.api.apps.v1.DaemonSetSpec; if you choose to ignore these errors, turn validation off with --validate=false

@murali-reddy murali-reddy merged commit b54b80c into cloudnativelabs:master Aug 1, 2019
ticpu pushed a commit to ticpu/kube-router that referenced this pull request Dec 10, 2019
@MarkDeckert @ticpu
update to apps/v1 and add selector (cloudnativelabs#759)
0c3ece5
mk01 pushed a commit to mk01/kube-router-ipv6 that referenced this pull request Mar 12, 2020
@MarkDeckert @mk01
update to apps/v1 and add selector (cloudnativelabs#759)
f5274eb 
(cherry picked from commit b54b80c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update daemonset from "extensions/v1beta1" to "apps/v1"
2 participants
@MarkDeckert @murali-reddy