Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NPCs: Hex Codes #1311

Closed
1 task done
Roomiiaan opened this issue Oct 18, 2023 · 2 comments · Fixed by #1321
Closed
1 task done

NPCs: Hex Codes #1311

Roomiiaan opened this issue Oct 18, 2023 · 2 comments · Fixed by #1321
Labels
s: needs triage Issue waiting for triage t: feature request A request of a feature someone wants to see in a future release.

Comments

@Roomiiaan
Copy link

Describe the new feature

Add an option to also work with hex codes in the CloudNet-NPC module.

Why do you need this feature?

The CloudNet-Bridge module also allows to work with hex codes. Only a few people still use Minecraft's standard color codes.

Alternatives

Other

You could also think about supporting the "MiniMessage" format. Paper also has integrated the Adventure API.

https://docs.advntr.dev/minimessage/index.html

Issue uniqueness

  • Yes, this issue is unique. There are no similar issues.
@Roomiiaan Roomiiaan added s: needs triage Issue waiting for triage t: feature request A request of a feature someone wants to see in a future release. labels Oct 18, 2023
@0utplay
Copy link
Member

0utplay commented Oct 18, 2023

As far as I can tell you are talking about the info lines right? If thats the case you acutally can use hex color codes but you have to use the bungeecord format (it's horrible) &x&a&b&c&d&e&f

@Roomiiaan
Copy link
Author

Roomiiaan commented Oct 18, 2023 •
edited
Loading

As far as I can tell you are talking about the info lines right? If thats the case you acutally can use hex color codes but you have to use the bungeecord format (it's horrible) &x&a&b&c&d&e&f

Best time to support normal hex codes (same as in the bridge module) or adventure api

@0utplay 0utplay mentioned this issue Oct 21, 2023
Merged
derklaro pushed a commit that referenced this issue Feb 25, 2024
@0utplay
feat: support the adventure format in npc armorstand names (#1321)
89f4084 
### Motivation
We are supporting adventure and bungeecord color formatting at most
places. Do the same for the armorstands of npcs.

### Modification
Translated the adventure color format back to bungeecord to support the
format in the name of armorstands.

### Result
Adventure is supported for armorstands of npcs.

##### Other context
Fixes #1311
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
s: needs triage Issue waiting for triage t: feature request A request of a feature someone wants to see in a future release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support the adventure format in npc armorstand names CloudNetService/CloudNet
2 participants
@Roomiiaan @0utplay