Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refer to proper module #38

Closed
wants to merge 1 commit into from
Closed

Refer to proper module #38

wants to merge 1 commit into from

Conversation

jhosteny
Copy link
Contributor

@jhosteny jhosteny commented May 6, 2021

what

why

  • Module import reference is incorrect

references

This should have been fixed in #35, but was forgotten.
@jhosteny jhosteny requested review from a team as code owners May 6, 2021 21:06
@@ -232,7 +232,7 @@ __NOTE:__ For the example, we import all the CLI modules, but they could be incl
"git::https://git@github.com/cloudposse/atmos@modules/helm?ref=master",
"git::https://git@github.com/cloudposse/atmos@modules/workflow?ref=master",
"git::https://git@github.com/cloudposse/atmos@modules/istio?ref=master",
"git::https://git@github.com/cloudposse/atmos@modules/vendor?ref=master"
"git::https://git@github.com/cloudposse/atmos@modules/vendir?ref=master"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that needs to be fixed in https://github.com/cloudposse/atmos/blob/master/README.yaml#L209

and then run

make init
make readme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants