Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process component attribute for helmfile. Add settings and env sections to stack config outputs #40

Merged
merged 12 commits into from
May 28, 2021

Conversation

aknysh
Copy link
Member

@aknysh aknysh commented May 28, 2021

what

  • Process component attribute for helmfile
  • Add settings and env sections to atmos stack config outputs
  • Add --config-type=describe parameter to atmos stack config command

why

  • Process component attribute in helmfile commands - make helmfile module the same as the terraform module and allow using the component attribute to reference the base component with default values
 √ . example ⨠ atmos helmfile diff nginx-ingress-2 -s ue2-dev
"environment": "ue2"
"installed": true
"namespace": "eg"
"region": "us-east-2"
"stage": "dev"
"test": false

helmfile --state-values-file ./ue2-dev-nginx-ingress-2.helmfile.vars.yaml diff
rm ./components/helmfile/nginx-ingress/ue2-dev-nginx-ingress-2.helmfile.vars.yaml
  • Add settings and env sections to stack config outputs - make atmos compatible with the latest additions to YAML stack configs

  • Add --config-type=describe parameter to atmos stack config command - show all (deep-merged) sections for a component in one output - helps with debugging YAML configs

√ . example ⨠ atmos stack config nginx-ingress-2 -s ue2-dev --config-type=describe --component-type=helmfile
"backend": {}
"backend-type": "s3"
"command": "helmfile"
"component": "nginx-ingress"
"env": {}
"settings": {}
"vars":
  "environment": "ue2"
  "installed": true
  "namespace": "eg"
  "region": "us-east-2"
  "stage": "dev"
  "test": false
 √ . example ⨠ atmos stack config vpc2 -s ue2-dev --config-type=describe
"backend": {}
"backend-type": "s3"
"command": "terraform"
"component": "vpc"
"env":
  "ENV_TEST_1": "test1_override"
  "ENV_TEST_2": "test2_override"
  "ENV_TEST_3": "test3"
  "ENV_TEST_4": "test4"
"settings":
  "spacelift":
    "autodeploy": true
    "branch": "test"
    "triggers":
    - "a"
    - "b"
    - "c"
    "workspace_enabled": true
  "version": 0
"vars":
  "cidr_block": "10.108.0.0/18"
  "environment": "ue2"
  "namespace": "eg"
  "region": "us-east-2"
  "stage": "dev"
  "test-map":
    "a": "a3"
    "atr":
      "atr1": "1-1"
      "atr2": "2-3"
      "atr3": 3
      "atr4": 4
      "list":
      - "1b"
    "atr-2":
      "atr1": 1
      "atr2": 2
    "b": "b2"
    "c": "c1"
    "d": "d3"
    "e": "e3"
    "g": "g1"
    "list":
    - 4
    - 5
    - 6
    "list2":
    - 1
    - 2
    - 3

related

@aknysh aknysh self-assigned this May 28, 2021
@aknysh aknysh requested review from a team as code owners May 28, 2021 01:57
@aknysh aknysh requested a review from johncblandii May 28, 2021 01:58
Nuru
Nuru previously approved these changes May 28, 2021
Copy link
Sponsor Contributor

@Nuru Nuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aknysh approved, but please respond to comments above.

johncblandii
johncblandii previously approved these changes May 28, 2021
Copy link
Contributor

@johncblandii johncblandii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thx for working through this, @aknysh!

@aknysh aknysh dismissed stale reviews from johncblandii and Nuru via 2536948 May 28, 2021 18:16
@aknysh aknysh requested review from Nuru and johncblandii May 28, 2021 18:19
@aknysh
Copy link
Member Author

aknysh commented May 28, 2021

@aknysh approved, but please respond to comments above.

@Nuru I responded to the comments, please re-review

@aknysh aknysh merged commit 2c99477 into master May 28, 2021
@aknysh aknysh deleted the add-new-features branch May 28, 2021 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants