-
-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Process component
attribute for helmfile
. Add settings
and env
sections to stack config
outputs
#40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # .github/workflows/auto-release.yml
Nuru
reviewed
May 28, 2021
Nuru
reviewed
May 28, 2021
Nuru
previously approved these changes
May 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aknysh approved, but please respond to comments above.
johncblandii
previously approved these changes
May 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thx for working through this, @aknysh!
johncblandii
approved these changes
May 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
component
attribute forhelmfile
settings
andenv
sections toatmos stack config
outputs--config-type=describe
parameter toatmos stack config
commandwhy
component
attribute inhelmfile
commands - makehelmfile
module the same as theterraform
module and allow using thecomponent
attribute to reference the base component with default valuesAdd
settings
andenv
sections tostack config
outputs - makeatmos
compatible with the latest additions to YAML stack configsAdd
--config-type=describe
parameter toatmos stack config
command - show all (deep-merged) sections for a component in one output - helps with debugging YAML configsrelated
component
support #39