[incubator/monochart] Add new chart #155

alebabai · 2018-08-10T14:39:35Z

what

add monochart (moved from helm-chart-scaffolding)

references

#5
#6
#9

osterman · 2018-08-12T20:04:27Z

incubator/monochart/Chart.yaml

@@ -0,0 +1,10 @@
+apiVersion: v1
+description: Helm Chart


A declarative helm chart for deploying common types of services on kubernetes

osterman · 2018-08-12T20:04:39Z

incubator/monochart/LICENSE

+      same "printed page" as the copyright notice for easier
+      identification within third-party archives.
+
+   Copyright [yyyy] [name of copyright owner]


osterman · 2018-08-12T20:05:00Z

incubator/monochart/README.md

@@ -0,0 +1,3 @@
+# Helm Chart Scaffolding
+
+Use this chart when creating new charts to make it easy to get up and running quickly. 


Use the description from above

osterman · 2018-08-12T20:05:07Z

incubator/monochart/README.md

@@ -0,0 +1,3 @@
+# Helm Chart Scaffolding


Rename to Monochart

osterman · 2018-08-12T20:07:31Z

incubator/monochart/templates/daemonset.yaml

+        - configMapRef:
+            name: {{ include "common.fullname" . }}
+        env:
+{{- range $name, $value := .Values.env.open }}


We need to pick one of these ways of exporting envs, because currently we export all envs twice.

Maybe we use this values format?

env: configMap: USER: bar secrets: PASSWORD: secret inline: DEBUG: true

Or maybe we should use this format, since we already have sections for job, deployment, service, etc... we should do the same for configMap and secret resource types.

configMap: env: USER: bar files: "/etc/test.conf": "foo" secrets: env: PASS: secret files: "/etc/ssl/test.crt": |- ... # Inline env env: USER: test

osterman · 2018-08-12T20:11:08Z

incubator/monochart/values.yaml

+config:
+#   name: value
+env:
+  open:


See above. I think we should have configMap, secrets and inline types

@osterman good point, but I have some thoughts about this.
Configmap usually contains properties like a.b.c: value and this is not really an environment variable (it's looks like the set of config-files more)

Yea, what about dropping the env top-level convention and instead doing:

configMaps: env: FOO: bar files: "/etc/blah.conf": "asd" secrets: # same....

yeap, this variant looks good

I've pushed a PR to common chart with changes required to render env from configmaps.
But do we need dependency on common chart or monochart should have all required templates?

osterman · 2018-08-12T20:13:10Z

incubator/monochart/values.yaml

@@ -0,0 +1,108 @@
+replicaCount: 1
+image:
+  repository: nginx


Let's leave this blank and error if not set.

osterman · 2018-08-12T20:13:24Z

incubator/monochart/values.yaml

+replicaCount: 1
+image:
+  repository: nginx
+  tag: 0.1.0


Let's leave this blank and error if not set.

@osterman i'll should revert these changes, because it breaks CI.

osterman · 2018-08-12T20:16:11Z

incubator/monochart/values.yaml

+  #   annotations:
+  ##    Read more about kube2iam to provide access to s3 https://github.com/jtblin/kube2iam
+  #     iam.amazonaws.com/role: role-arn
+service:


Add enabled flag

osterman · 2018-08-12T20:16:31Z

incubator/monochart/values.yaml

+    cpu: 80m
+    memory: 64Mi
+persistence:
+  Enabled: false


let's lowercase first character

osterman · 2018-08-12T20:17:03Z

incubator/monochart/values.yaml

+  #   annotations:
+  ##    Read more about kube2iam to provide access to s3 https://github.com/jtblin/kube2iam
+  #     iam.amazonaws.com/role: role-arn
+statefulset:


Add enabled flag

osterman · 2018-08-12T20:17:08Z

incubator/monochart/values.yaml

+    ENV_NAME: ENV_VALUE
+  secret:
+    SECRET_ENV_NAME: SECRET_ENV_VALUE
+deployment:


Add enabled flag

osterman · 2018-08-12T20:17:13Z

incubator/monochart/values.yaml

+  #   annotations:
+  ##    Read more about kube2iam to provide access to s3 https://github.com/jtblin/kube2iam
+  #     iam.amazonaws.com/role: role-arn
+daemonset:


Add enabled flag

osterman · 2018-08-12T20:17:18Z

incubator/monochart/values.yaml

+  #   annotations:
+  ##    Read more about kube2iam to provide access to s3 https://github.com/jtblin/kube2iam
+  #     iam.amazonaws.com/role: role-arn
+job:


Add enabled flag

osterman · 2018-08-12T20:32:02Z

incubator/monochart/templates/daemonset.yaml

+        emptyDir: {}
+      {{- end -}}
+
+      - name: config


We need to generalize this configuration and give it a proper section in values.yaml:

e.g.

configFiles: "/etc/test.conf": |- [default] debug=true

osterman · 2018-08-12T20:33:11Z

incubator/monochart/templates/daemonset.yaml

+          - key: special.level
+            path: keys
+
+      - name: secret


We need to generalize this too.

aknysh · 2018-08-14T16:42:03Z

incubator/monochart/Chart.yaml

+version: 0.1.0
+appVersion: 0.1.0
+home: https://github.com/cloudposse/charts/tree/master/incubator/monochart
+icon: https://github.com/cloudposse/charts/tree/master/incubator/monochart/logo.png


wrong logo URL

aknysh · 2018-08-14T16:42:40Z

incubator/monochart/README.md

@@ -0,0 +1,3 @@
+# Monochart
+
+A declarative helm chart for deploying common types of services on kubernetes.


Capitalize Kubernetes

aknysh · 2018-08-14T16:42:50Z

incubator/monochart/Chart.yaml

@@ -0,0 +1,10 @@
+apiVersion: v1
+description: A declarative helm chart for deploying common types of services on kubernetes


Capitalize Kubernetes

add default values for annotations

* make probes configurable * improve resources template * simplify service template (based on newer helm base chart)

…nochart

to follow k8s spec and to be able to work on k8s 1.9+

osterman · 2018-08-29T00:37:14Z

incubator/monochart/templates/job.yaml

+        args: {}
+        ports:
+          - name: http
+            containerPort: 8080


Parameterize?

osterman · 2018-08-29T00:37:33Z

incubator/monochart/templates/statefulset.yaml

+        args: {}
+        ports:
+          - name: http
+            containerPort: 8080


Parameterize?

In newer version of helm (2.9.1 and higher) when your create chart via helm create chart_name it has some changes in service template and deployments ports and i think it really reasonable changes. Service have only one parameterized port - external one, and containers port is hardcoded with assigned name.
I'll explain.
Container port depends on docker image that you use therefore it is unlikely that it will ever be changed - so it can be hardcoded directly in deployment, but it shoud have a name http in this case. External port of the service is some kind of interface so it shoud be configurable.

I think that makes sense for a custom built chart for a single purpose. But this is a universal chart so I think it’s better we parameteize it for more interoperability. Eg node apps default on 3000.

aknysh · 2018-08-29T15:15:11Z

incubator/monochart/requirements.yaml

@@ -0,0 +1,4 @@
+dependencies:
+- name: common


do we still need this if we have _helpers.tpl as well?

osterman · 2018-08-29T15:15:39Z

incubator/monochart/values.yaml

+  #   - "docker-secret-1"
+  #   - "docker-secret-2"
+
+configMap:


Add support for labels so that we can use with Grafana

osterman · 2018-08-29T15:18:54Z

incubator/monochart/templates/statefulset.yaml

+        args: {}
+        ports:
+          - name: http
+            containerPort: 8080


I think that makes sense for a custom built chart for a single purpose. But this is a universal chart so I think it’s better we parameteize it for more interoperability. Eg node apps default on 3000.

aknysh · 2018-08-29T15:58:11Z

incubator/monochart/values.yaml

+  pod:
+    ## Pod annotations
+    annotations: {}
+    ## Read more about kube2iam to provide access to s3 https://github.com/jtblin/kube2iam


do we need a reference to kube2iam here since we mostly use kiam?

osterman · 2018-08-29T17:22:41Z

Let's move all changes/fixes/enhancements to a new PR.

alebabai added 2 commits August 10, 2018 17:32

feat(incubator): create monochart

f448273

fix(incubator.monochart): add empty lines

d04f1bd

alebabai requested review from osterman and goruha August 10, 2018 14:39

osterman reviewed Aug 12, 2018

View reviewed changes

incubator/monochart/README.md Outdated

@@ -0,0 +1,3 @@

# Helm Chart Scaffolding

Copy link

Member

osterman Aug 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename to Monochart

osterman reviewed Aug 12, 2018

View reviewed changes

osterman changed the title ~~Incubator - Add monochart~~ [monochart] Add new chart Aug 12, 2018

osterman reviewed Aug 12, 2018

View reviewed changes

incubator/monochart/values.yaml Outdated

cpu: 80m

memory: 64Mi

persistence:

Enabled: false

Copy link

Member

osterman Aug 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's lowercase first character

osterman reviewed Aug 12, 2018

View reviewed changes

alebabai added 4 commits August 13, 2018 17:52

refactor(incubator.monochart): fix title and description

748a8a7

refactor(incubator.monochart): fix license

3804aa2

refactor(incubator.monochart): add enbled flags

de6c6b3

refactor(incubator.monochart): update pvc

fc43c97

osterman changed the title ~~[monochart] Add new chart~~ [incubator/monochart] Add new chart Aug 14, 2018

osterman requested a review from aknysh August 14, 2018 16:35

aknysh reviewed Aug 14, 2018

View reviewed changes

alebabai added 10 commits August 23, 2018 19:27

refactor(incubator.monochart): standatify pods values

7981292

fix(incubator.monochart): fix image

c6b8d06

refactor(incubator.monochart): fix render

2248100

add default values for annotations

refactor(incubator.monochart): hide empty annotations block

1d663a4

refactor(incubator.monochart): annotation - use with

57a4a3f

refactor(incubator.monochart): improvements

e0a3ba2

* make probes configurable * improve resources template * simplify service template (based on newer helm base chart)

Merge branch 'master' of github.com:cloudposse/charts into feature/mo…

1f313b1

…nochart

fix(incubator.monochart): lint

92334d5

refactor(incubator.monochart): update strategy support

005acc0

refactor(incubator.monochart): env restructuring WIP

acc889a

alebabai added the wip label Aug 28, 2018

alebabai added 6 commits August 29, 2018 02:14

refactor(incubator.monochart): env template WIP

34140da

refactor(incubator.monochart): fix struct merge

5ee410d

refactor(incubator.monochart): add enabled to configMap

f7eac04

refactor(incubator.monochart): fix secret and configmap empty input

16ec945

refactor(incubator.monochart): improve ingress codebase

4233ed0

refactor(incubator.monochart): add selectors

24cd2a3

to follow k8s spec and to be able to work on k8s 1.9+

alebabai removed the wip label Aug 29, 2018

alebabai self-assigned this Aug 29, 2018

osterman reviewed Aug 29, 2018

View reviewed changes

incubator/monochart/templates/job.yaml

args: {}

ports:

- name: http

containerPort: 8080

Copy link

Member

osterman Aug 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parameterize?

osterman reviewed Aug 29, 2018

View reviewed changes

alebabai and others added 2 commits August 29, 2018 12:18

refactor(incubator.monochart): split configmap/secret to env & files

50ca396

Disable all resources by default

033ad5d

aknysh reviewed Aug 29, 2018

View reviewed changes

osterman approved these changes Aug 29, 2018

View reviewed changes

aknysh reviewed Aug 29, 2018

View reviewed changes

osterman merged commit 4248d1c into master Aug 29, 2018

osterman mentioned this pull request Aug 29, 2018

[incubator/monochart] Extend chart capabilities #158

Closed

aknysh deleted the feature/monochart branch January 11, 2019 03:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[incubator/monochart] Add new chart #155

[incubator/monochart] Add new chart #155

alebabai commented Aug 10, 2018 •

edited

Loading

osterman Aug 12, 2018

osterman Aug 12, 2018

osterman Aug 12, 2018

osterman Aug 12, 2018

osterman Aug 12, 2018 •

edited

Loading

osterman Aug 14, 2018 •

edited

Loading

osterman Aug 12, 2018

alebabai Aug 13, 2018

osterman Aug 13, 2018

alebabai Aug 15, 2018

alebabai Aug 15, 2018

osterman Aug 12, 2018

osterman Aug 12, 2018

alebabai Aug 22, 2018

osterman Aug 12, 2018

osterman Aug 12, 2018

osterman Aug 12, 2018

osterman Aug 12, 2018

osterman Aug 12, 2018

osterman Aug 12, 2018

osterman Aug 12, 2018

osterman Aug 12, 2018

aknysh Aug 14, 2018

aknysh Aug 14, 2018

aknysh Aug 14, 2018

osterman Aug 29, 2018

osterman Aug 29, 2018

alebabai Aug 29, 2018 •

edited

Loading

osterman Aug 29, 2018

aknysh Aug 29, 2018

osterman Aug 29, 2018

osterman Aug 29, 2018

aknysh Aug 29, 2018

osterman commented Aug 29, 2018

		@@ -0,0 +1,3 @@
		# Helm Chart Scaffolding

		Use this chart when creating new charts to make it easy to get up and running quickly.

		@@ -0,0 +1,3 @@
		# Monochart

		A declarative helm chart for deploying common types of services on kubernetes.

		@@ -0,0 +1,10 @@
		apiVersion: v1
		description: A declarative helm chart for deploying common types of services on kubernetes

[incubator/monochart] Add new chart #155

[incubator/monochart] Add new chart #155

Conversation

alebabai commented Aug 10, 2018 • edited Loading

what

references

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

osterman Aug 12, 2018 • edited Loading

Choose a reason for hiding this comment

osterman Aug 14, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alebabai Aug 29, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

osterman commented Aug 29, 2018

alebabai commented Aug 10, 2018 •

edited

Loading

osterman Aug 12, 2018 •

edited

Loading

osterman Aug 14, 2018 •

edited

Loading

alebabai Aug 29, 2018 •

edited

Loading