[fzf] Fix for non-interactive mode #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osterman
changed the title
goruha
approved these changes
Mar 1, 2019
tamsky
reviewed
Mar 1, 2019
| @@ -0,0 +1,5 @@ | |||
| # Install fzf shell completion when an interactive shell is enabled | |||
| # This is a fix for: `/etc/bash_completion.d/fzf.sh: line 34: bind: warning: line editing not enabled` | |||
| if [ -t 1 ]; then | |||
There was a problem hiding this comment.
Is this our standard test method for detecting interactive shells?
I'm used to $PS1 or $-
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
fzfif non-interactive terminalwhy
Closes fzf.sh: line 34: bind: warning: line editing not enabled #351