[rootfs/templates/wrapper] Use docker native filtering with ps #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osterman
changed the title
Nuru
reviewed
Mar 20, 2019
| echo "# Attaching to existing ${DOCKER_NAME} session" | ||
|
|
||
| local container_id=$(docker ps --quiet --filter name="${DOCKER_NAME}" --format "{{`{{ .ID }}`}}") | ||
| if [ -n "$container_id" ]; then |
There was a problem hiding this comment.
This gets around the pipefail problem, but perpetuates another problem, such as if one container's name is a substring of another's it will match (men.cloudposse.co will match women.cloudposse.co). Is there a more robust way to check for this container being run?
Nuru
reviewed
Mar 20, 2019
Nuru
previously approved these changes
Mar 20, 2019
Nuru
approved these changes
Mar 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
docker ps --filteroption rather than pipe/grep patternwhy
pipefailis unreliable, so lets just eliminate it as a factor in this case