Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename helmfiles to releases #76

Merged
merged 2 commits into from Jan 14, 2019
Merged

Rename helmfiles to releases #76

merged 2 commits into from Jan 14, 2019

Conversation

goruha
Copy link
Member

@goruha goruha commented Jan 10, 2019

What

  • Rename helmfiles to releases

Why

  • Naming dir helmfiles was a mistake.

aknysh
aknysh reviewed Jan 10, 2019
View reviewed changes
README.yaml Outdated Show resolved Hide resolved
aknysh
aknysh reviewed Jan 10, 2019
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

osterman
osterman requested changes Jan 11, 2019
View reviewed changes
Copy link
Member

@osterman osterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@aknysh @goruha
Apply suggestions from code review
0fdec91 
Co-Authored-By: goruha <goruha@gmail.com>
@goruha goruha merged commit 7aba0fa into master Jan 14, 2019
@goruha goruha deleted the rename-dirs branch January 14, 2019 10:30
@daveyu daveyu mentioned this pull request Jan 22, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknysh aknysh aknysh left review comments

@osterman osterman osterman approved these changes

Assignees

@osterman osterman

@goruha goruha

@aknysh aknysh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@goruha @osterman @aknysh