Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent env vars naming conflicts #103

Merged
merged 15 commits into from
Dec 6, 2018
Merged

Prevent env vars naming conflicts #103

merged 15 commits into from
Dec 6, 2018

Conversation

goruha
Copy link
Member

@goruha goruha commented Dec 5, 2018

What

  • Replace NAME variable with PACKAGE_NAME

Why

  • To prevent conflicts between build-harness slack notification module and packages
  • To prevent env vars naming conflicts in future.

@goruha goruha requested a review from osterman December 5, 2018 21:29
@osterman osterman merged commit a482123 into master Dec 6, 2018
@osterman osterman deleted the prevent-env-vars-naming-conflicts branch December 6, 2018 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osterman osterman osterman approved these changes

Assignees

@osterman osterman

@goruha goruha

@aknysh aknysh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@goruha @osterman @aknysh