Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add zone_name and zone_id to readme #67

Closed
wants to merge 2 commits into from
Closed

docs: add zone_name and zone_id to readme #67

wants to merge 2 commits into from

Conversation

nitrocode
Copy link
Member

what

  • add zone_name and zone_id to readme

why

  • show how to use the module and be explicit about the zone to add validation records to

references

@nitrocode nitrocode requested review from a team as code owners March 3, 2023 13:40
@nitrocode nitrocode added the no-release Do not create a new release (wait for additional code changes) label Mar 3, 2023
@acorncom
Copy link

It'd be handy to have info about the zone options higher up in the readme, any chance we can get this merged?

@github-actions
Copy link

github-actions bot commented May 9, 2023

README.md is outdated. Please run the following command locally and push the file.

make init 
make readme

Nuru
Nuru requested changes Feb 27, 2024
View reviewed changes
Copy link
Sponsor Contributor

@Nuru Nuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After #66, this is no longer accurate. Subject alternative names are not considered when trying to determine Zone.

@hans-d hans-d added the stale This PR has gone stale label Mar 6, 2024
@hans-d
Copy link

hans-d commented Mar 6, 2024

@Nuru @nitrocode can we close this pr (given the latest remark)? if not, it will be closed soon if the pr does not get any sensible update.

@mergify Mergify
Copy link

mergify bot commented Mar 9, 2024

Important

README.md is out of date.

Rebuild the README.md by running make readme and commit the changes.

make init
make readme

Could you fix it @nitrocode? 🙏

@nitrocode nitrocode closed this Mar 10, 2024
@mergify mergify bot removed the stale This PR has gone stale label Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nuru Nuru Nuru requested changes

@acorncom acorncom acorncom approved these changes

@dotCipher dotCipher Awaiting requested review from dotCipher dotCipher is a code owner automatically assigned from cloudposse/contributors

@florian0410 florian0410 Awaiting requested review from florian0410 florian0410 is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
no-release Do not create a new release (wait for additional code changes)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nitrocode @acorncom @hans-d @Nuru @max-lobur