Revert "Allow management of ACM certs with SANs in multiple zones (#61)" #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2eec7e5.
This was referenced Mar 3, 2023
Merged
Nuru
added
the
no-release
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| domain => length(split(".", domain)) > 2 ? join(".", slice(split(".", domain), 1, length(split(".", domain)))) : domain | ||
| } | ||
| unique_zones = distinct(values(local.domain_to_zone)) | ||
| private_enabled = ! local.public_enabled |
There was a problem hiding this comment.
[terraform fmt -recursive] reported by reviewdog 🐶
Suggested change
| private_enabled = ! local.public_enabled | |
| private_enabled = !local.public_enabled |
| @@ -51,7 +42,7 @@ resource "aws_route53_record" "default" { | |||
| type = dvo.resource_record_type | |||
| } | |||
| } | |||
| zone_id = data.aws_route53_zone.default[local.domain_to_zone[each.key]].id | |||
| zone_id = join("", data.aws_route53_zone.default.*.zone_id) | |||
There was a problem hiding this comment.
List items should be accessed using square brackets
Nuru
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Workaround for now is to use 0.16.3
what
why
zone_id/zone_namewhich should be able to be overridden resulting in the the data sourceaws_route53_zonecontinuing to be created per unique domain but resolving to thezone*passed in.references