Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Override target group name #63

Merged
merged 2 commits into from
Jul 6, 2022
Merged

Override target group name #63

merged 2 commits into from
Jul 6, 2022

Conversation

nitrocode
Copy link
Member

what

  • Override target group name

why

  • Target group name is limited to 32 chars
  • Overriding it will allow us to tag it correctly using the context and reduce the name
  • Workaround is to create the target group outside of the module and feed it in, but that's no fun

references

N/A

@nitrocode nitrocode requested review from a team as code owners July 6, 2022 03:15
@nitrocode
Copy link
Member Author

/test all

@nitrocode nitrocode merged commit eff37d8 into master Jul 6, 2022
@nitrocode nitrocode deleted the target_group_name branch July 6, 2022 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamengual jamengual jamengual approved these changes

@aknysh aknysh aknysh approved these changes

@dotCipher dotCipher Awaiting requested review from dotCipher dotCipher was automatically assigned from cloudposse/contributors

@brcnblc brcnblc Awaiting requested review from brcnblc brcnblc was automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nitrocode @jamengual @aknysh @cloudpossebot