Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: lambda@edge submodule #204

Merged
merged 27 commits into from
Dec 28, 2021
Merged

Feat: lambda@edge submodule #204

merged 27 commits into from
Dec 28, 2021

Conversation

korenyoni
Copy link
Member

@korenyoni korenyoni commented Dec 20, 2021

what

  • Add submodule for creating Lambda@Edge functions
  • Add test for Lambda@Edge submodule
  • Ensure all tests run in parallel.
  • Fix versions.tf in examples/complete according to TFLint

why

  • Lambda@Edge are a potentially common use case for this repo, and a submodule for creating Lambda@Edge functions for use with the root module should be created.

references

  • N/A

notes

Please note that a side effect of this change is that the test suite will now take ~30 minutes to run.

Copy link

@bridgecrew bridgecrew bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bridgecrew has found infrastructure configuration errors in this PR ⬇️

modules/lambda@edge/main.tf Show resolved Hide resolved
modules/lambda@edge/main.tf Show resolved Hide resolved
modules/lambda@edge/main.tf Show resolved Hide resolved
modules/lambda@edge/main.tf Show resolved Hide resolved
Copy link

@bridgecrew bridgecrew bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️   Due to c5d87b8 - Add BridgeCrew exceptions. - 4 errors were fixed.

Change details

Error ID Change Path Resource
BC_AWS_SERVERLESS_4 Fixed /modules/lambda@edge/main.tf aws_lambda_function.default
BC_AWS_GENERAL_63 Fixed /modules/lambda@edge/main.tf aws_lambda_function.default
BC_AWS_GENERAL_64 Fixed /modules/lambda@edge/main.tf aws_lambda_function.default
BC_AWS_GENERAL_65 Fixed /modules/lambda@edge/main.tf aws_lambda_function.default

@korenyoni
Copy link
Member Author

/test all

@korenyoni
Copy link
Member Author

/test all

@korenyoni korenyoni marked this pull request as ready for review December 27, 2021 20:50
@korenyoni korenyoni requested review from a team as code owners December 27, 2021 20:50
@korenyoni korenyoni requested review from dotCipher and max-lobur and removed request for a team December 27, 2021 20:50
goruha
goruha previously approved these changes Dec 28, 2021
@korenyoni
Copy link
Member Author

/test all

@korenyoni
Copy link
Member Author

/test all

goruha
goruha previously approved these changes Dec 28, 2021
@korenyoni
Copy link
Member Author

/test all

goruha
goruha previously approved these changes Dec 28, 2021
modules/lambda@edge/main.tf Outdated Show resolved Hide resolved
modules/lambda@edge/main.tf Outdated Show resolved Hide resolved
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a few nitpicks

Co-authored-by: Andriy Knysh <aknysh@users.noreply.github.com>
@korenyoni
Copy link
Member Author

/test all

@korenyoni korenyoni merged commit cdf1d5c into master Dec 28, 2021
@korenyoni korenyoni deleted the feat/lambda-at-edge branch December 28, 2021 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants