Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change mixed instances policy fields to optional #126

Merged

Conversation

pagmerek
Copy link
Contributor

what

  • change variable field of mixed_instances_policy to optional

why

In my other PR for terraform ECS component I changed the default value of variable that is being passed here. Without this change terraform will complain that there is no such field as instances_distribution/override

references

NOTE: This PR must be merged first and then I will change version of ASG component in ECS component

@pagmerek pagmerek force-pushed the mixed-instances-policy-fields-as-optional branch from b3f3681 to 9cf1551 Compare October 31, 2023 11:48
@goruha
Copy link
Member

goruha commented Nov 6, 2023

/terratest

@goruha
Copy link
Member

goruha commented Nov 6, 2023

/terratest

@goruha goruha merged commit 8a38b85 into cloudposse:main Nov 6, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants