Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default empty value #25

Merged
merged 6 commits into from
Nov 20, 2023

Conversation

pagmerek
Copy link
Contributor

@pagmerek pagmerek commented Oct 31, 2023

what

  • Remove default null field in mixed instances policy

why

According to terraform docs:

An optional attribute with a non-null default value is guaranteed to never have the value null within the receiving module. 
Terraform will substitute the default value both when a caller omits the attribute altogether and when a caller explicitly
sets it to null, thereby avoiding the need for additional checks to handle a possible null value. 

In ASG Cloudposse component here you can see that on any value that is not null it will create mixed_instances_policy

references

@goruha
Copy link
Member

goruha commented Nov 14, 2023

/terratest

README.md Outdated Show resolved Hide resolved
docs/terraform.md Outdated Show resolved Hide resolved
@goruha
Copy link
Member

goruha commented Nov 20, 2023

/terratest

README.md Outdated Show resolved Hide resolved
docs/terraform.md Outdated Show resolved Hide resolved
@goruha
Copy link
Member

goruha commented Nov 20, 2023

/terratest

@goruha goruha merged commit 7b47140 into cloudposse:main Nov 20, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants