Remove optional domain attribute from aws_eip resource (#173)

Co-authored-by: Joe Niland <joe@originalmind.com.au> Co-authored-by: Hans Donner <hans@hansdonner.nl>
cloudposse · Mar 20, 2024 · 5dd574d · 5dd574d
1 parent 12a2d7d
commit 5dd574d
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 2 deletions.
diff --git a/eni.tf b/eni.tf
@@ -26,6 +26,5 @@ resource "aws_network_interface_attachment" "additional" {
 resource "aws_eip" "additional" {
   #bridgecrew:skip=BC_AWS_NETWORKING_48: Skiping `Ensure all EIP addresses allocated to a VPC are attached to EC2 instances` because it is incorrectly flagging that this instance does not belong to a VPC even though subnet_id is configured.
   count             = local.additional_ips_count
-  domain            = "vpc"
   network_interface = aws_network_interface.additional[count.index].id
 }
diff --git a/main.tf b/main.tf
@@ -178,7 +178,6 @@ resource "aws_eip" "default" {
   #bridgecrew:skip=BC_AWS_NETWORKING_48: Skiping `Ensure all EIP addresses allocated to a VPC are attached to EC2 instances` because it is incorrectly flagging that this instance does not belong to a VPC even though subnet_id is configured.
   count    = var.associate_public_ip_address && var.assign_eip_address && module.this.enabled ? 1 : 0
   instance = one(aws_instance.default[*].id)
-  domain   = "vpc"
   tags     = module.this.tags
 }