Remove optional domain attribute from aws_eip resource
#173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariot8
changed the title
domain attribute from aws_eip resource to allow tf to compute the value
|
/terratest |
hans-d
added
stale
|
/terratest |
|
Thanks @mariot8 for creating this pull request! A maintainer will review your changes shortly. Please don't be discouraged if it takes a while. While you wait, make sure to review our contributor guidelines. Tip Need help or want to ask for a PR review to be expedited?Join us on Slack in the |
|
/terratest |
joe-niland
approved these changes
Mar 20, 2024
There was a problem hiding this comment.
Thanks @mariot8
Just a general note that the other option for domain was "standard" which is no longer valid due to EC2 Classic Networking being retired.
joe-niland
changed the title
domain attribute from aws_eip resource to allow tf to compute the valuedomain attribute from aws_eip resource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
aws_eipoptionaldomainattributewhy
domainattribute causes terraform to fail plan EC2 instancereferences
aws_eipcauses terraform fail #172