Adding external ENIs #159
Merged
Adding external ENIs #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/terratest |
![bridgecrew[bot]](https://avatars.githubusercontent.com/in/52968?s=60&v=4){kind=small}
|
/terratest |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
aknysh
reviewed
Jun 6, 2023
aknysh
reviewed
Jun 6, 2023
There was a problem hiding this comment.
@jamengual thanks for the PR, please see comments.
Also, in the file https://github.com/cloudposse/terraform-aws-ec2-instance/blob/main/test/src/Makefile
we have
## Run tests
test: init
go mod download
go test -v -timeout 60m -run TestExamplesComplete
this will run only one test TestExamplesComplete and will not run the test that you added.
To run the test that you added, please do the following:
- Add your test here https://github.com/cloudposse/terraform-aws-ec2-instance/blob/main/test/src/examples_complete_test.go as a separate Go function
- Update this
## Run tests
test: init
go mod download
go test -v -timeout 60m -run TestExamplesComplete
to this
## Run tests
test: init
go mod download
go test -v -timeout 60m
This will run all the Go tests.
Thanks you
Co-authored-by: Andriy Knysh <aknysh@users.noreply.github.com>
|
/terratest |
|
/terratest |
|
/terratest |
|
/terratest |
|
/terratest |
aknysh
reviewed
Jun 6, 2023
outputs.tf
Outdated
| @@ -73,7 +73,7 @@ output "additional_eni_ids" { | |||
|
|
|||
| output "ebs_ids" { | |||
| description = "IDs of EBSs" | |||
| value = aws_ebs_volume.default[*].id | |||
| value = one(aws_ebs_volume.default[*].id) | |||
There was a problem hiding this comment.
this aws_ebs_volume.default[*].id was correct since the output name is ebs_ids and we want a list of EIPs
|
/terratest |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
/terratest |
…s-ec2-instance into add_external_eni
|
/terratest |
|
I can't see the bridecrew issue but I though they were all addressed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Add the ability to add external ENIs to the instance
why
For ec2 instances deployments clusters where the IPs are required to be unique and not change it is necessary to create ENIs outside of this module so that the instance termination does not change the ENI and IP attached.
references