-
-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding external ENIs #159
Merged
Merged
Adding external ENIs #159
Changes from 1 commit
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
b80b193
Adding external ENIs
jamengual 7694d19
Adding docs
jamengual c76b5f4
Updating examples modules
jamengual 48e59e4
adding new example and fixing vars
jamengual 5879ed5
Update examples/external-eni/main.tf
jamengual 8ee1427
Update examples/external-eni/main.tf
jamengual 857eea7
Update examples/external-eni/main.tf
jamengual 8b8510b
Update examples/external-eni/main.tf
jamengual 3f4f66c
Update examples/external-eni/main.tf
jamengual c794194
Update examples/external-eni/main.tf
jamengual 456fdcc
Update examples/external-eni/main.tf
jamengual 23b367f
fmt
jamengual 0ae66a4
reade
jamengual 189bda6
tflint fixes
jamengual 73c0210
tflint fixes
jamengual 95e131b
precommit/terraform
max-lobur bec6730
Fixing complete example
jamengual ce9a432
Update examples/complete/main.tf
jamengual e1b50ff
Fixing complete example
jamengual aa2d69a
Merge branch 'add_external_eni' of github.com:cloudposse/terraform-aw…
jamengual 144ac1e
Update readme
jamengual dbbf36d
Update to bridcrew rules
jamengual d28fb05
Update to bridcrew rules
jamengual 25f5e6f
Update to bridcrew rules
jamengual e4b09fd
Update to bridcrew rules
jamengual ba91b96
Update to bridgecrew rules
jamengual 6903584
Update outputs.tf
jamengual d3d1231
Addresing feedback and adding new test to run
jamengual 303eb1c
Addresing feedback and adding new test to run
jamengual ec9a6a4
Addresing feedback and adding new test to run
jamengual ea6d3b5
fixing tests
jamengual 9d46c45
fixing tests
jamengual a60001a
addressing feedback
jamengual eed46b1
Update outputs.tf
jamengual 09c4f0e
addressing feedback
jamengual 50818e9
Merge branch 'add_external_eni' of github.com:cloudposse/terraform-aw…
jamengual File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this
aws_ebs_volume.default[*].id
was correct since the output name isebs_ids
and we want a list of EIPs