Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding external ENIs #159

Merged
merged 36 commits into from
Jun 7, 2023
Merged
Changes from 1 commit
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
b80b193
Adding external ENIs
jamengual May 30, 2023
7694d19
Adding docs
jamengual May 31, 2023
c76b5f4
Updating examples modules
jamengual May 31, 2023
48e59e4
adding new example and fixing vars
jamengual May 31, 2023
5879ed5
Update examples/external-eni/main.tf
jamengual May 31, 2023
8ee1427
Update examples/external-eni/main.tf
jamengual May 31, 2023
857eea7
Update examples/external-eni/main.tf
jamengual May 31, 2023
8b8510b
Update examples/external-eni/main.tf
jamengual May 31, 2023
3f4f66c
Update examples/external-eni/main.tf
jamengual May 31, 2023
c794194
Update examples/external-eni/main.tf
jamengual May 31, 2023
456fdcc
Update examples/external-eni/main.tf
jamengual May 31, 2023
23b367f
fmt
jamengual May 31, 2023
0ae66a4
reade
jamengual May 31, 2023
189bda6
tflint fixes
jamengual May 31, 2023
73c0210
tflint fixes
jamengual May 31, 2023
95e131b
precommit/terraform
max-lobur May 31, 2023
bec6730
Fixing complete example
jamengual May 31, 2023
ce9a432
Update examples/complete/main.tf
jamengual May 31, 2023
e1b50ff
Fixing complete example
jamengual May 31, 2023
aa2d69a
Merge branch 'add_external_eni' of github.com:cloudposse/terraform-aw…
jamengual May 31, 2023
144ac1e
Update readme
jamengual Jun 2, 2023
dbbf36d
Update to bridcrew rules
jamengual Jun 2, 2023
d28fb05
Update to bridcrew rules
jamengual Jun 2, 2023
25f5e6f
Update to bridcrew rules
jamengual Jun 2, 2023
e4b09fd
Update to bridcrew rules
jamengual Jun 2, 2023
ba91b96
Update to bridgecrew rules
jamengual Jun 2, 2023
6903584
Update outputs.tf
jamengual Jun 6, 2023
d3d1231
Addresing feedback and adding new test to run
jamengual Jun 6, 2023
303eb1c
Addresing feedback and adding new test to run
jamengual Jun 6, 2023
ec9a6a4
Addresing feedback and adding new test to run
jamengual Jun 6, 2023
ea6d3b5
fixing tests
jamengual Jun 6, 2023
9d46c45
fixing tests
jamengual Jun 6, 2023
a60001a
addressing feedback
jamengual Jun 6, 2023
eed46b1
Update outputs.tf
jamengual Jun 6, 2023
09c4f0e
addressing feedback
jamengual Jun 6, 2023
50818e9
Merge branch 'add_external_eni' of github.com:cloudposse/terraform-aw…
jamengual Jun 6, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion outputs.tf
Expand Up @@ -73,7 +73,7 @@ output "additional_eni_ids" {

output "ebs_ids" {
description = "IDs of EBSs"
value = aws_ebs_volume.default[*].id
value = one(aws_ebs_volume.default[*].id)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this aws_ebs_volume.default[*].id was correct since the output name is ebs_ids and we want a list of EIPs

}

output "primary_network_interface_id" {
Expand Down