Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ecs service iam role is unused #51

Closed
nitrocode opened this issue May 29, 2020 · 0 comments · Fixed by #52
Closed

ecs service iam role is unused #51

nitrocode opened this issue May 29, 2020 · 0 comments · Fixed by #52
Labels
bug 🐛 An issue with the system

Comments

@nitrocode
Copy link
Member

nitrocode commented May 29, 2020 •
edited
Loading

Describe the Bug

ecs service iam role is created yet unused

Expected Behavior

ecs service iam role is both created and used

Steps to Reproduce

The ecs service terraform resource does not supply the iam_role argument

Screenshots

N/A

Environment (please complete the following information):

N/A

Additional Context

https://www.terraform.io/docs/providers/aws/r/ecs_service.html
@nitrocode nitrocode added the bug 🐛 An issue with the system label May 29, 2020
nitrocode added a commit to nitrocode/terraform-aws-ecs-alb-service-task that referenced this issue May 29, 2020
@nitrocode
Use the ecs service role
71b4401 
Fixes cloudposse#51
@nitrocode nitrocode mentioned this issue May 29, 2020
Merged
aknysh added a commit that referenced this issue May 31, 2020
@nitrocode @aknysh
Use the ecs service role (#52)
19b680d 
* Use the ecs service role

Fixes #51

* Update main.tf

Co-authored-by: Andriy Knysh <aknysh@users.noreply.github.com>

* Update main.tf

Co-authored-by: Andriy Knysh <aknysh@users.noreply.github.com>

* Use iam_role if not in awsvpc mode

* Only create service role if network_mode is not awsvpc

* Add network_mode check to iam policy and role policy

* Remove test for service role arn

Co-authored-by: Andriy Knysh <aknysh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 An issue with the system
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use the ecs service role nitrocode/terraform-aws-ecs-alb-service-task
1 participant
@nitrocode