Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make log_configuration's secretOptions optional #76

Merged
merged 11 commits into from
Jun 16, 2020
Merged

Make log_configuration's secretOptions optional #76

merged 11 commits into from
Jun 16, 2020

Conversation

nitrocode
Copy link
Member

@nitrocode nitrocode commented Jun 10, 2020 •
edited
Loading

Fixes #75 by setting a default value for secretOptions as shown in this comment.

@aknysh @osterman review please

@nitrocode
Copy link
Member Author

/codefresh run test

@nitrocode nitrocode requested review from a team, Gowiem and jamengual and removed request for a team June 11, 2020 22:17
@osterman
Copy link
Member

/test all

@osterman
Copy link
Member

/rebuild-readme

@osterman
Copy link
Member

/terraform-fmt

osterman
osterman requested changes Jun 13, 2020
View reviewed changes
Copy link
Member

@osterman osterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix tests

image

@nitrocode
Copy link
Member Author

/test all

@nitrocode
Copy link
Member Author

/terraform-fmt

@nitrocode
Copy link
Member Author

/rebuild-readme

@nitrocode
Copy link
Member Author

/test all

@nitrocode nitrocode requested a review from osterman June 14, 2020 21:14
@nitrocode
Copy link
Member Author

/test all

@nitrocode
Copy link
Member Author

@osterman not sure why but the readme update action deleted all the inputs in the docs...

@nitrocode
Copy link
Member Author

/rebuild-readme

@osterman
Copy link
Member

@nitrocode very wierd! haven't seen that one happen before.

@osterman
Copy link
Member

/rebuild-readme

@nitrocode
Copy link
Member Author

cloudposse/build-harness#218

@osterman
Copy link
Member

/rebuild-readme

@nitrocode
Copy link
Member Author

@osterman looks like the major difference in the docs is the escaping of underscores using \_

@osterman
Copy link
Member

@nitrocode this is the new version of terraform-docs

Previously we used an atrocious hack because for the longest time terraform-docs did not support 0.12. The underscores are intentional, I believe, to ensure proper markdown formatting in all cases.

@osterman
Copy link
Member

Additional context about the backslashes here: terraform-docs/terraform-docs#111

@osterman
Copy link
Member

Looks like we can add --no-escape to get rid of it. terraform-docs/terraform-docs#117

@osterman
Copy link
Member

I'm okay either way. Want to wait and PR the build-harness or fix conflicts and merge? =)

@nitrocode
Copy link
Member Author

/test all

@osterman
Copy link
Member

/rebuild-readme

@osterman
Copy link
Member

/test readme

@osterman
Copy link
Member

/test all

@nitrocode nitrocode merged commit af45dda into cloudposse:master Jun 16, 2020
@nitrocode nitrocode deleted the patch-1 branch June 16, 2020 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osterman osterman osterman approved these changes

@Gowiem Gowiem Awaiting requested review from Gowiem

@jamengual jamengual Awaiting requested review from jamengual

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

log_configuration shouldn't require optional key secretOptions
3 participants
@nitrocode @osterman @actions-bot