Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

variables.tf: transition_to_ia -- add AFTER_1_DAY as valid value #130

Merged
merged 5 commits into from
Dec 2, 2023

Conversation

michw
Copy link
Contributor

@michw michw commented Sep 24, 2023

what

  • Add AFTER_1_DAY as a valid value for transition_to_ia
  • Add efs_file_system_policy resource

why

  • AFTER_1_DAY is a valid value for transition_to_ia argument for lifecycle policy.
  • efs_file_system_policy resource was missing.

@michw michw requested review from a team as code owners September 24, 2023 12:27
@michw
Copy link
Contributor Author

michw commented Nov 29, 2023

anybody ?

@Gowiem
Copy link
Member

Gowiem commented Nov 29, 2023

/terratest

@Gowiem
Copy link
Member

Gowiem commented Nov 29, 2023

Hey @michw, sadly this is blocked as we need to upgrade the VPC module version in our examples/complete. See here on a similar issue: cloudposse/terraform-aws-rds#157 (review)

Can you give that a shot and push your changes and we'll work to get this reviewed and merged?

@Gowiem
Copy link
Member

Gowiem commented Nov 29, 2023

/terratest

examples/complete/versions.tf: bump hashicorp/aws and terraform
@michw
Copy link
Contributor Author

michw commented Nov 30, 2023

FWIW it passed when running local with make docker/test 😁

@Gowiem
Copy link
Member

Gowiem commented Nov 30, 2023

/terratest

@Gowiem
Copy link
Member

Gowiem commented Dec 2, 2023

/terratest

@Gowiem Gowiem merged commit a981c28 into cloudposse:main Dec 2, 2023
9 checks passed
@Gowiem
Copy link
Member

Gowiem commented Dec 2, 2023

Thanks for the hard work and patience @michw. This will be released as https://github.com/cloudposse/terraform-aws-efs/releases/tag/0.35.0 shortly 👍

@michw
Copy link
Contributor Author

michw commented Dec 2, 2023

No worries, it was fun.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants