Add New Attributes #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osterman
approved these changes
Dec 13, 2018
osterman
reviewed
Dec 13, 2018
osterman
reviewed
Dec 13, 2018
osterman
requested changes
Dec 13, 2018
Co-Authored-By: johncblandii <johncblandii@users.noreply.github.com>
Co-Authored-By: johncblandii <johncblandii@users.noreply.github.com>
aknysh
reviewed
Dec 14, 2018
aknysh
reviewed
Dec 14, 2018
aknysh
reviewed
Dec 14, 2018
aknysh
reviewed
Dec 14, 2018
aknysh
reviewed
Dec 14, 2018
|
Ready for a final review. |
aknysh
requested changes
Dec 14, 2018
There was a problem hiding this comment.
thanks @johncblandii
for the final touch, please run terraform fmt, TravisCI is failing
https://travis-ci.org/cloudposse/terraform-aws-efs/builds/467832858
osterman
previously approved these changes
Dec 28, 2018
aknysh
reviewed
Dec 28, 2018
outputs.tf
Outdated
| description = "DNS name" | ||
| } | ||
|
|
||
| output "mount_target_dns_names" { | ||
| value = "${aws_efs_mount_target.default.*.dns_name}" |
There was a problem hiding this comment.
Suggested change
| value = "${aws_efs_mount_target.default.*.dns_name}" | |
| value = "[${aws_efs_mount_target.default.*.dns_name}"] |
There was a problem hiding this comment.
@johncblandii sorry, I missed this.
Since we use [] in all other outputs (e.g. network_interface_ids), let's make it consistent.
netflash
referenced
this pull request
in netflash/terraform-aws-efs
Apr 25, 2020
…ssh_keys_to_workers Allow adding SSH keys to worker ASGs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
why