-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
alarm names should be unique #5
Comments
100% agree. We should be using the |
Any chance you have time to submit a PR for this @SevereOverfl0w ? |
Potentially, I'll drop a note here if I find the time and start working on it. It is a problem for us as we have multiple dbs, so I'll be inclined to fix it at some point. |
Until a better solution is implemented, I've added unicity based on instance ID via PR #10 |
.... just add the rds_instance_id in front of the alarm name with a dash in local testing, it fixes the issue: |
This can be easily fixed by including the instance id before the alarm name, example:
|
terraform doesn't complain about the conflict, but the alarms will constantly have their dimension overwritten with every deploy if the names aren't unique.
The text was updated successfully, but these errors were encountered: