Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alarm names should be unique #5

Closed
SevereOverfl0w opened this issue Aug 11, 2018 · 6 comments · Fixed by #33
Closed

alarm names should be unique #5

SevereOverfl0w opened this issue Aug 11, 2018 · 6 comments · Fixed by #33
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@SevereOverfl0w
Copy link
Contributor

terraform doesn't complain about the conflict, but the alarms will constantly have their dimension overwritten with every deploy if the names aren't unique.

@osterman
Copy link
Member

100% agree. We should be using the terraform-null-label module here.

@osterman osterman added the enhancement New feature or request label Aug 12, 2018
@osterman
Copy link
Member

Any chance you have time to submit a PR for this @SevereOverfl0w ?

@osterman osterman added the help wanted Extra attention is needed label Aug 12, 2018
@SevereOverfl0w
Copy link
Contributor Author

Potentially, I'll drop a note here if I find the time and start working on it. It is a problem for us as we have multiple dbs, so I'll be inclined to fix it at some point.

rebelthor pushed a commit to rebelthor/terraform-aws-rds-cloudwatch-sns-alarms that referenced this issue Mar 6, 2019
@rebelthor
Copy link

rebelthor commented Mar 6, 2019

Until a better solution is implemented, I've added unicity based on instance ID via PR #10

@RoryKiefer
Copy link

RoryKiefer commented Aug 30, 2019

.... just add the rds_instance_id in front of the alarm name with a dash

in local testing, it fixes the issue:
alarm_name: "swap_usage_too_high" => "clutchwh-swap_usage_too_high" (forces new resource)

@SnufflesC137
Copy link

SnufflesC137 commented Nov 18, 2019

This can be easily fixed by including the instance id before the alarm name, example:

alarm_name = "${var.db_instance_id}_cpu_utilization_too_high"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment